Comment #1 originally posted by Alexey-Yakovenko on 2014-08-18T13:44:56.000Z:

Great, thanks for the detailed description, etc, but wouldn't it have been easier to just submit a patch? :)

Comment #2 originally posted by Alexey-Yakovenko on 2014-08-18T15:16:25.000Z:

I will at some point, but if it is an immediate problem then I have an immediate solution.

Do you think resetting a blank mask to the default makes sense? An empty mask is almost equivalent to setting the checkbox off. An empty mask actually still searches for *.jpg and *.jpeg, but that isn't obvious to the users.

Comment #3 originally posted by Alexey-Yakovenko on 2014-08-18T19:52:06.000Z:

Hey, attachments allowed again. Make my day! Here's a quick patch to fix the crash.

Still lots of ideas:

• blanking the mask sets it back to the default;
• symlinking local files instead of copying them;
• only retrying http fetches for missing files every hour or so, and maybe only retrying local searches at a shorter interval, but not many times a second as now;
• still don't know what an API between decoders and artwork (for non-junk tags) should look like.

Also spotted a possible (well, pretty certain, but not tested yet) memory leak in the file globbing code. The individual array strings from scandir are freed but not the array itself. Will add a fix to my development version.

Comment #4 originally posted by Alexey-Yakovenko on 2014-08-18T20:29:23.000Z:

I forgot to mention ideas for cache cleanup ...

When artwork is unavailable, an empty directory is still created. Might become moot if unavailable artwork needs to be tracked to avoid too many lookups.

Even invalidated cache files still remain on disk forever. No imminent nightmare, but they should probably be culled when they're thoroughly expired. Would probably need to be done on a separate thread, slowly.

Comment #5 originally posted by Alexey-Yakovenko on 2014-08-18T20:34:07.000Z:

This will have to become a sort of garbage collector. Or just add an explicit button to delete all expired files, with a progress bar. A topic for a separate bug/request though. Closing this one, the patch is merged.