Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON example in dynamic properties #51

Closed
peterdesmet opened this issue Nov 28, 2014 · 4 comments
Closed

Update JSON example in dynamic properties #51

peterdesmet opened this issue Nov 28, 2014 · 4 comments

Comments

@peterdesmet
Copy link
Member

The example for dynamicProperties includes the following JSON:

{'heightInMeters':'1.5'}
{'tragusLengthInMeters':'0.014', 'weightInGrams':'120'}
{'natureOfID':'expert identification', 'identificationEvidence':'cytochrome B sequence'}
{'relativeHumidity':'28', 'airTemperatureInCelcius':'22', 'sampleSizeInKilograms':'10'}{'aspectHeading':'277', 'slopeInDegrees':'6'}
{'iucnStatus':'vulnerable', 'taxonDistribution':'Neuquén, Argentina'}

JSON requires strings to be in double quotes, while the example shows single quotes. That's probably because every example is in double quotes - it would be better to have those as inline code, but that's another issue - but it's wrong none the less.

Why are all the numbers in quotes? Numbers don't require those. So, I would suggest to update the example to:

Examples: "{"heightInMeters":1.5}", "{"tragusLengthInMeters":0.014, "weightInGrams":120}", "{"natureOfID":"expert identification", "identificationEvidence":"cytochrome B sequence"}", "{"relativeHumidity":28, "airTemperatureInCelcius":22, "sampleSizeInKilograms":10}", "{"aspectHeading":277, "slopeInDegrees":6}", "{"iucnStatus":"vulnerable", "taxonDistribution":"Neuquén, Argentina"}". For discussion see http://terms.tdwg.org/wiki/dwc:dynamicProperties

@tucotuco
Copy link
Member

tucotuco commented Dec 6, 2014

Done in d429461.

@tucotuco tucotuco closed this as completed Dec 6, 2014
@peterdesmet
Copy link
Member Author

What needs to be done to have this change reflected on the website?

@tucotuco
Copy link
Member

tucotuco commented Dec 8, 2014

I attempted an SVN commit to rs.tdwg.org/dwc with these same updates and
I'm getting the following message:

Error: Server sent unexpected return value (502 Bad Gateway) in response to
CHECKOUT

Has there already been a redirect that makes SVN fail to do the commit? If
so, what indeed needs to be done to make the changes appear live?

On Mon, Dec 8, 2014 at 9:39 AM, Peter Desmet notifications@github.com
wrote:

What needs to be done to have this change reflected on the website?


Reply to this email directly or view it on GitHub
#51 (comment).

@mdoering
Copy link
Contributor

merged the master branch into gh-pages which serves now rs.tdwg-org/dwc:
http://rs.tdwg.org/dwc/terms/index.htm#dynamicProperties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants