New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DartDoc support for mixins. (ListBase from dart:collection with incorrect inheritance) #9925
Comments
In both the new and old dartdoc ListBase is now shown. It seems to be incorrect that it says it extends Object and implements ListMixin, but otherwise seems ok. Changing description appropriately. I had been looking for an example of mixin use in the core libraries to check that. Set owner to @alan-knight. |
ListBase is actually declared as "typedef ListBase<E> = Object with ListMixin<E>", so the description is correct. |
Well, not correct if it doesn't mention the mixin, but not completely wrong either. |
I have this CL for it: https://codereview.chromium.org/57983002/ |
Removed the owner. |
Removed Area-DartDocNext label. |
Removed Library-Docgen label. |
ListBase is fine but repurposing this to show mixins more directly. |
Set owner to @alan-knight. |
Use the helper methods getAppliedMixins, getExplicitInterfaces, getSuperclass, isMixinApplication defined in sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart to user-oriented view upon mixins. |
Added Pkg-DartDoc label. |
Removed Area-DartDoc label. |
Removed Pkg-DartDoc label. |
I just hit this for https://api.dartlang.org/apidocs/channels/be/dartdoc-viewer/dart-collection.UnmodifiableMapBase The comment that should get shown is: instead nothing is displayed... |
Removed this from the Later milestone. |
Added this to the 1.6 milestone. |
Removed Oldschool-Milestone-Later label. |
DartDoc (per api.dartlang.org) doesn't have any entry for the class ListBase in dart:collection.
The ListBase class is defined using a typedef, which may not be supported by DartDoc yet. It's declaration is:
typedef ListBase = Object with ListMixin;
This declares a non-abstract class, and it should be in DartDoc on equal terms with other classes.
Function-type typedefs are supported (like Comparator).
The text was updated successfully, but these errors were encountered: