Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag missing hashCode #9671

Closed
stevemessick opened this issue Apr 4, 2013 · 7 comments
Closed

Flag missing hashCode #9671

stevemessick opened this issue Apr 4, 2013 · 7 comments
Assignees
@bwilkerson
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

It would be great if teh analyzer/editor issued a warning whenever operator== is overriden but not hashCode (or the contrary).
////////////////////////////////////////////////////////////////////////////////////
Editor: 0.4.4_r20810 (2013-04-03)
OS: Linux - amd64 (3.2.5-gg1130)
JVM: 1.7.0-google-v5

projects: 2

open dart files: 17

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 943 / 943 / 694 MB
thread count: 22
analysis: 0 tasks, 169 libraries, 1 contexts
index: 216775 relationships and 0 attributes in 32368 elements in 754 resources stored in 6 MB on disk

SDK installed: true
Dartium installed: true
analysis engine: dartc
@bwilkerson
Copy link
Member

Removed Area-Editor label.
Added Area-Analyzer label.

@peter-ahe-google
Copy link
Contributor

FYI: I'm about to add this feature to dart2js, see: https://codereview.chromium.org/17588005/.

@bwilkerson
Copy link
Member

Added Analyzer-Hint label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@stevemessick stevemessick added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

Live reproduction: https://dartpad.dartlang.org/8d4c86ae4c25f3866de476afd8b6868d

@bwilkerson
Copy link
Member

There is now a lint rule for this (hash_and_equals).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @srawlins @kasperl @peter-ahe-google @bwilkerson @stevemessick