Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: make noSuchMethod on native classes work again #9631

Open
rakudrama opened this issue Apr 3, 2013 · 13 comments
Open

dart2js: make noSuchMethod on native classes work again #9631

rakudrama opened this issue Apr 3, 2013 · 13 comments
Assignees
@rakudrama
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@rakudrama
Copy link
Member

Moving native classes to interceptors broke noSuchMethod on native classes.

Option 1: put generic noSuchMethod hooks on Object.prototype that redirect to the isolate.

Option 2: all methods use the interceptor convention when a native class defines noSuchMethod. The hooks can then be placed on $.Object
@rakudrama
Copy link
Member Author

Marked this as blocking #9729.

@kasperl
Copy link

kasperl commented Apr 22, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Have this been fixed already?

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Sep 18, 2013

What's the status of this, Stephen? Is it something that has already been fixed? Do we need to get it fixed for M7?

Set owner to @rakudrama.
Removed this from the Later milestone.
Added this to the M7 milestone.

@rakudrama
Copy link
Member Author

It is not fixed.
With custom elements it is possible, so we should fix it.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@rakudrama rakudrama self-assigned this Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@sigmundch
Copy link
Member

@rakudrama - i believe this is now working, correct?

@rakudrama
Copy link
Member Author

I doubt it.

@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakudrama rakudrama

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @sigmundch @rakudrama @vsmenon @kasperl