Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: make constant hash codes stable. #9477

Open
rakudrama opened this issue Mar 28, 2013 · 7 comments
Open

dart2js: make constant hash codes stable. #9477

rakudrama opened this issue Mar 28, 2013 · 7 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@rakudrama
Copy link
Member

The hashcodes for the Constant hierarchy are unstable and host dependent.

r20603 introduced a constant hasher for generating stable names.

This issue is a work item to fold that hashcode function (or another stable, host independent one) into the primary hash mechanism for Constants.
@kasperl
Copy link

kasperl commented Apr 22, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@lrhn
Copy link
Member

lrhn commented Sep 18, 2013

Why is the hashCode of a constant important?
What about constants of classes that override hashCode?

@lrhn
Copy link
Member

lrhn commented Sep 18, 2013

Nevermind, I missed that this was the internal Constant class of dart2js, not the Dart constants themselves.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @rakudrama @vsmenon @kasperl @lrhn