Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecating a call() method #9470

Closed
DartBot opened this issue Mar 27, 2013 · 12 comments
Closed

deprecating a call() method #9470

DartBot opened this issue Mar 27, 2013 · 12 comments
Assignees
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Mar 27, 2013

This issue was originally filed by @bp74


What steps will reproduce the problem?

import 'package:meta/meta.dart';

class foo {
  @­deprecated
  call(String name) {
    print("hello $name");
  }
  sayHello(String name) {
    print("hello $name");
  }
}

void main() {
  var f = new foo();
  f("Thomas");
  f.sayHello("Thomas");
}

What is the expected output? What do you see instead?

The Dart Editor strikes through the "call" method in the "foo" class, but there is no warning from the Dart Analyzer in the "main" method. The Dart Editor should signal that f("Thomas") is deprecated.

What version of the product are you using? On what operating system?

Dart Editor version 0.1.2_r20560
Dart SDK version 0.1.2.0_r20560

Please provide any additional information below.

@dgrove
Copy link
Contributor

dgrove commented Mar 28, 2013

Added Area-Analyzer, Triaged labels.

@bwilkerson
Copy link
Member

Added this to the M5 milestone.

@bwilkerson
Copy link
Member

Removed this from the M5 milestone.
Added this to the M6 milestone.

@bwilkerson
Copy link
Member

Removed this from the M6 milestone.
Added this to the M7 milestone.

@jwren
Copy link
Member

jwren commented Sep 19, 2013

M7 -> M8


Removed this from the M7 milestone.
Added this to the M8 milestone.

@bwilkerson
Copy link
Member

Removed this from the M8 milestone.
Added this to the Later milestone.

@bwilkerson
Copy link
Member

Added Analyzer-Hint label.

@bwilkerson
Copy link
Member

Removed Type-Defect label.
Added Type-Enhancement label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot DartBot added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

@srawlins srawlins self-assigned this Apr 26, 2016
srawlins added a commit that referenced this issue Apr 27, 2016
BUG=#9470

Example output:

$ cat -n a.dart
     1  class Foo {
     2    Foo foo;
     3
     4    @deprecated
     5    call(String name) {
     6      print("hello $name");
     7    }
     8  }
     9
    10  void main() {
    11    Foo f = new Foo();
    12    f("Thomas");
    13    f.foo = new Foo();
    14    f.foo("Timmy");
    15  }
$ xcodebuild/ReleaseX64/dart-sdk/bin/dartanalyzer a.dart
Analyzing [a.dart]...
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart, line 12, col 3)
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart, line 14, col 3)
2 hints found.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1922563003 .
@srawlins
Copy link
Member

Done in 2cfa9c4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants