Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dart:svg.AnimatedXyz with Animated<Xyz> #9268

Closed
DartBot opened this issue Mar 19, 2013 · 5 comments
Closed

replace dart:svg.AnimatedXyz with Animated<Xyz> #9268

DartBot opened this issue Mar 19, 2013 · 5 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-svg P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Mar 19, 2013

This issue was originally filed by @seaneagan


The following classes in dart:svg:

AnimatedAngle
AnimatedBoolean
AnimatedEnumeration
AnimatedInteger
AnimatedLength
AnimatedLengthList
AnimatedNumber
AnimatedNumberList
AnimatedPreserveAspectRatio
AnimatedRect
AnimatedString
AnimatedTransformList

could all be replaced by the following interface:

class Animated<T> {
  /// A read only [T] representing the current animated value of the given
  /// attribute. If the given attribute is not currently being animated,
  /// then the [T] will have the same contents as baseVal. The object
  /// referenced by animVal is always distinct from the one referenced
  /// by baseVal, even when the attribute is not animated.
  final T animVal;

  final T baseVal;
}

@madsager
Copy link
Contributor

Added Area-Library, Library-Svg, Triaged labels.

@lrhn
Copy link
Member

lrhn commented Aug 19, 2013

Removed Type-Defect label.
Added Type-Enhancement label.

@lrhn
Copy link
Member

lrhn commented Jan 28, 2014

Removed Area-Library label.
Added Area-HTML label.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library label.

@DartBot DartBot added Type-Enhancement library-svg area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Apr 7, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@terrylucas
Copy link
Contributor

Will not fix the library is generated from the Chrome IDLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-svg P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants