Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting library names within an isolate should be allowed (dart2js) #9054

Closed
gbracha opened this issue Mar 11, 2013 · 10 comments
Closed

Conflicting library names within an isolate should be allowed (dart2js) #9054

gbracha opened this issue Mar 11, 2013 · 10 comments
Assignees
@johnniwinther
Labels
web-dart2js

Comments

@gbracha
Copy link
Contributor

gbracha commented Mar 11, 2013

Per the resolution of bug 5715, it is no longer a compile-time error to import two libraries of the same name in the same isolate.
@kasperl
Copy link

kasperl commented Apr 22, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@lrhn
Copy link
Member

lrhn commented Mar 6, 2015

Dart2js no longer considers duplicate library names as an error, but it also doesn't seem to give the required warning.

Added Spec-Violation label.

@floitschG
Copy link
Contributor

cc @johnniwinther.

@johnniwinther
Copy link
Member

lrn@: Do you have a repo? We have code and test for the issue so something is checked.

@lrhn
Copy link
Member

lrhn commented Apr 8, 2015

The missing warning may be due to my script-to-run-dart2js not showing the warning if compilation otherwise succeeds. When I run sdk/bin/dart2js directly, there is a warning.

@johnniwinther
Copy link
Member

Set owner to @johnniwinther.
Added Fixed label.

@gbracha gbracha mentioned this issue Jun 4, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kasperl @gbracha @lrhn @floitschG @johnniwinther