Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the paths returned for script urls #9031

Closed
devoncarew opened this issue Mar 9, 2013 · 4 comments
Closed

Change the paths returned for script urls #9031

devoncarew opened this issue Mar 9, 2013 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

I have some pretty unfortunate logic in the Editor's debugger to recognize when a script's source should be requested from Dartium vs. read from the local file system. I'd like to clean that code up. Right now I look for scripts with path's similar to:

file:///Volumes/data/b/build/slave/dartium-mac-inc/build/src/xcodebuild/DerivedSources/Release/webkit/bindings/dart/dart/html/Element.dart

but I'd much rather the url was something that started with 'dart:'. In this case, maybe something like 'dart:html/Element.dart'.
@DartBot
Copy link

DartBot commented Mar 11, 2013

This comment was originally written by podivilov@google.com

Removed the owner.
Removed Area-Dartium label.
Added Area-VM label.

@DartBot
Copy link

DartBot commented Mar 11, 2013

This comment was originally written by podivilov@google.com

Those sources are snapshotted during the build, and full paths are recorded into snapshot by gen_snapshot. Passing to VM team.

cc @a-siva.

@iposva-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Unassigned label.

@devoncarew devoncarew added Type-Enhancement area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jun 5, 2013
@iposva-google
Copy link
Contributor

Stale.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @devoncarew @iposva-google @DartBot