Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some library name validation warn instead of error #8632

Closed
munificent opened this issue Feb 19, 2013 · 3 comments
Closed

Make some library name validation warn instead of error #8632

munificent opened this issue Feb 19, 2013 · 3 comments
Assignees
@munificent
Labels
type-enhancement A request for a change that isn't a bug
Milestone
M4

Comments

@munificent
Copy link
Member

When publishing a package, we validate library names:

  1. Cannot be empty.
  2. Can only contain identifier characters.
  3. Must start with a letter.
  4. Cannot be a Dart reserved word.
  5. Should be all lowercase.

Currently, 2, 3, and 4 are errors, not warnings. After some discussion, we've decided to make those warn. (5 is already a warning, and 1 will remain an error.)
@munificent
Copy link
Member Author

Added Started label.

@munificent
Copy link
Member Author

Added Fixed label.

@munificent munificent self-assigned this Feb 21, 2013
@munificent munificent added this to the M4 milestone Feb 21, 2013
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#455.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
M4
Development

No branches or pull requests
3 participants
@kevmoo @munificent @DartBot