Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: stable order for interceptor names #8506

Closed
rakudrama opened this issue Feb 12, 2013 · 8 comments
Closed

dart2js: stable order for interceptor names #8506

rakudrama opened this issue Feb 12, 2013 · 8 comments
Labels
web-dart2js

Comments

@rakudrama
Copy link
Member

The names constructed for interceptors is sensitive to perturbations in the source code.

E.g.: swarm
@r18319
     t3 = $.getInterceptor$JSArrayJSString(t2);
@r18399
     t3 = $.getInterceptor$JSStringJSArray(t2);
@rakudrama
Copy link
Member Author

Fix available: https://codereview.chromium.org/12224130

@kasperl
Copy link

kasperl commented Apr 22, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@srawlins
Copy link
Member

https://codereview.chromium.org/12224130 was committed. I think this can be closed.

@floitschG
Copy link
Contributor

thanks.

Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @rakudrama @kasperl @floitschG