Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide one canonical way to deprecate code, that does not require a package #8476

Closed
sethladd opened this issue Feb 11, 2013 · 3 comments
Closed

Provide one canonical way to deprecate code, that does not require a package #8476

sethladd opened this issue Feb 11, 2013 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

There are at least three ways I've seen to deprecate code (from the core libraries)

package meta's @­deprecated

/**
 * @­deprecated
 */

/**
 * Deprecated.
 */

I'd love to see a single, canonical way to mark code as deprecated, without requiring me to install a package.

Deprecation is common through API evolution.
@lrhn
Copy link
Member

lrhn commented Feb 13, 2013

There is actually a fourth: @­deprecated with any constant definition of "deprecated". It seems the editor is using the syntactic form of "@deprecated" and not the value of the constant named "deprecated".

I agree that we should settle on one, and I prefer it to be kept inside the documentation comment, be it @­deprecated or Deprecated or anything inside **'s, like Deprecation warning: This won't work..

This is really a coordination problem involving library, editor and dartdoc.

@kevmoo
Copy link
Member

kevmoo commented Mar 1, 2013

See also

https://code.google.com/p/dart/issues/detail?id=6773
https://code.google.com/p/dart/issues/detail?id=8590

@sethladd sethladd added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Mar 1, 2013
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@lrhn
Copy link
Member

lrhn commented Aug 11, 2017

We now have @deprecated with deprecated declared in dart:core.

@lrhn lrhn closed this as completed Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sethladd @kevmoo @lrhn