Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor should use indentation and empty lines for better hints #8362

Closed
DartBot opened this issue Feb 6, 2013 · 10 comments
Closed

Editor should use indentation and empty lines for better hints #8362

DartBot opened this issue Feb 6, 2013 · 10 comments
Assignees
Labels
analyzer-recovery area-analyzer type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Feb 6, 2013

This issue was originally filed by source.s...@gmail.com


What steps will reproduce the problem?

  1. create a class
  2. create a field "Element example" (omit the semicolon at the end)
  3. create a constructor

What is the expected output? What do you see instead?

Expected: "Unexpected IDENTIFIER; you may be missing a semicolon on the previous line" or highlight the previous line and provide the error "Unexpected IDENTIFIER" or simply highlight the line and provide any other error since obviously anything other then equals sign, comma or semicolon are the only possible values for a field; therefore if anything other then those appears the error should be on the field.

Actual: highlighting constructor, and message "Unexpected token 'IDENTIFIER' (expected '(')"

What version of the product are you using? On what operating system?

Dart Editor version 0.3.4_r18115
Dart SDK version 0.3.4.0_r18115

Please provide any additional information below.

The current message should at least be changed to be more humane, ie. "Did not expect <insert class name> after <insert field name>"

@madsager
Copy link
Contributor

madsager commented Feb 7, 2013

Added Area-Editor, Triaged labels.

@clayberg
Copy link

Set owner to @scheglov.
Added this to the Later milestone.
Removed Type-Defect label.
Added Type-Enhancement label.

@scheglov
Copy link
Contributor

Removed the owner.
Removed Area-Editor label.
Added Area-Analyzer, AnalysisEngine labels.

@DartBot
Copy link
Author

DartBot commented Apr 7, 2013

This comment was originally written by amouravski@google.com


Added Editor-AnalysisEngine label.

@bwilkerson
Copy link
Member

Set owner to @bwilkerson.
Removed AnalysisEngine, Editor-AnalysisEngine labels.

@bwilkerson
Copy link
Member

Added Analyzer-Recovery label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@srawlins
Copy link
Member

srawlins commented Oct 9, 2015

This can be closed. The error is clear now:

class A {
  String foo // error: Expected to find ';'

  A();
}

https://dartpad.dartlang.org/bdb43c471932ca916d2a

@bwilkerson
Copy link
Member

Thanks for verifying this!

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-recovery area-analyzer type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

8 participants