Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid nested deprecation errors #8131

Closed
sigmundch opened this issue Jan 25, 2013 · 6 comments
Closed

avoid nested deprecation errors #8131

sigmundch opened this issue Jan 25, 2013 · 6 comments
Assignees
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@sigmundch
Copy link
Member

We currently get a deprecation warning/error for every deprecated symbol reachable from main. Would it be possible to only show the deprecation messages that are not covered by another deprecation message?

For example, in this code:

const deprecated = null;

@deprecated
bar() => null;

@deprecated
foo() => bar();

main() {
  foo();
}

It would be great if the warning is only shown when calling 'foo', but not where 'foo' is calling 'bar'.

Another example is in dart:html. The 'on' getter is deprecated, and every class returned by 'on' is as well. If a program uses 'on', today they get an error for every one of those classes inside of 'dart:html'.

This is exposing errors from inside 'dart:html' are not relevant for the end user.

@clayberg
Copy link

clayberg commented Feb 1, 2013

Set owner to @scheglov.
Added this to the Later milestone.

@scheglov
Copy link
Contributor

scheglov commented Apr 9, 2013

Set owner to @bwilkerson.
Removed Area-Editor label.
Added Area-Analyzer label.

@bwilkerson
Copy link
Member

Added Analyzer-Hint label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sigmundch sigmundch added Type-Enhancement area-analyzer analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

This was fixed at some point:

https://dartpad.dartlang.org/5640611cccfdd4a47f4298a157ef4438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants