Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need true reflective access to fields #7867

Closed
gbracha opened this issue Jan 11, 2013 · 6 comments
Closed

Need true reflective access to fields #7867

gbracha opened this issue Jan 11, 2013 · 6 comments
Assignees
@rmacnak-google
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors type-enhancement A request for a change that isn't a bug

Comments

@gbracha
Copy link
Contributor

gbracha commented Jan 11, 2013

The existing mirror library implementations of getField and setField do not provide access to the fields. They act as getter/setter invocations instead. We need true field access, and these new methods should be called getField and setField while the current ones are renamed.
@gbracha
Copy link
Contributor Author

gbracha commented Jan 11, 2013

See also issue #7866.

@iposva-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Unassigned label.

@lrhn
Copy link
Member

lrhn commented Aug 23, 2013

Added Library-Mirrors label.

@gbracha
Copy link
Contributor Author

gbracha commented Aug 23, 2013

We've decided that the solution to this lies in solving a more general problem: invoking code on super (or generally up the chain). So if a getter exists that is not just accessing a field, it must be overriding the implicit getter for the field, and we should be able to invoke that one.

@gbracha
Copy link
Contributor Author

gbracha commented Aug 23, 2013

Marked this as being blocked by #7538.

@gbracha gbracha added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. library-mirrors labels Aug 23, 2013
@gbracha gbracha self-assigned this Aug 23, 2013
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@zanderso zanderso added type-enhancement A request for a change that isn't a bug and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 5, 2017
This was referenced Jan 5, 2017
Closed
Closed
@rmacnak-google rmacnak-google added the closed-not-planned Closed as we don't intend to take action on the reported issue label Jan 5, 2017
@rmacnak-google
Copy link
Contributor

The use of mirrors has been undermined by the non-VM implementations. There is no appetite for further changes to the mirrors API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @gbracha @lrhn @iposva-google @zanderso @rmacnak-google