-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-check error on calling LinkedHashMap.keys #7754
Comments
Note that this started failing with the experimental merge. Related (I believe): This throws a type check in dart2js as well: While this does not: |
This is showing up now because lib_v2 uses parameterized typedefs. What is needed immediately is for checked mode type assertions to be 'optimistic'. Smaller example: typedef T Transformation<S, T>(S value); main() { o.js:230: type 'main_anon0' is not a subtype of type 'Transformation' $.main = function() { $$.main_anon = {"": "Closure;", $$.main_anon0 = {"": "Closure;", cc @karlklose. |
Set owner to @karlklose. |
Karl, is this still a critical unfixed issue? |
Johnni is working on function typechecks with type variables. I don't think it should block M4 because the libraries do not currently use type variables. cc @johnniwinther. |
Added TriageForM5 label. |
Sounds like this is on Johnni's plate. cc @lrhn. |
Removed Priority-Critical label. |
Fixed by https://codereview.chromium.org/12334070/. Added Fixed label. |
Calling LinkedHashMap.keys in dart2js checked mode throws a type-check error.
Repro:
var keys = new LinkedHashMap<int, int>().keys;
Error:
type '_LinkedHashMapImpl_keys_anon' is not a subtype of type '_Transformation'
The text was updated successfully, but these errors were encountered: