New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart2js: timer interface is not supported #7728
Comments
Added this to the M3 milestone. |
This comment was originally written by ngeoffray@google.com CL https://codereview.chromium.org/11866003/ implements support for non-repeating timers with 0 milliseconds delay. Other timers are still not supported. cc @floitschG. |
Issue #10109 has been merged into this issue. |
Added TriageForM5 label. |
Removed this from the M5 milestone. |
The d8 preamble now simulates non-zero timers as well. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
Working as intended. We can simulate some of their functionality but they are not available on these platforms. |
We could keep this bug, for the jsshell. There are still lots of tests that are marked as failing because of it, and it should be feasible (if not trivial) to adapt the v8 code for jsshell. |
I'm pretty sure we can just copy the d8 preamble and use it for jsshell as well. At least the timer code is completely generic. |
I don't think we need the "timers not available" code tested. |
It seems that we can get more value from having jsshell tested, so my preference is towards that too. Since the extra code lives in a preamble, we could technically also have extra test-only preambles if we want to cover specific error-code functionality. How complex would it be to add a single test that uses a test-specific preamble? Is that worth the effort? |
I don't think it's worth the effort. Our customers run in the browser, and there timers exist. |
sgtm |
…mers. BUG=#26060 BUG=#7728 R=kustermann@google.com Review URL: https://codereview.chromium.org/1871043002 .
(reopened to track adding timer support in the jsshell preamble, hopefully by simply coping it from the d8 preamble) |
There is no implementation for the Timer interface in generated JavaScript code. When trying to use timers with dart2js, an exception with description: "Timer interface not supported." occurs.
The text was updated successfully, but these errors were encountered: