Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js: timer interface is not supported #7728

Closed
karlklose opened this issue Jan 7, 2013 · 18 comments
Closed

dart2js: timer interface is not supported #7728

karlklose opened this issue Jan 7, 2013 · 18 comments

Comments

@karlklose
Copy link
Contributor

There is no implementation for the Timer interface in generated JavaScript code. When trying to use timers with dart2js, an exception with description: "Timer interface not supported." occurs.

@kasperl
Copy link

kasperl commented Jan 7, 2013

Added this to the M3 milestone.

@DartBot
Copy link

DartBot commented Jan 11, 2013

This comment was originally written by ngeoffray@google.com


CL https://codereview.chromium.org/11866003/ implements support for non-repeating timers with 0 milliseconds delay. Other timers are still not supported.


cc @floitschG.

@kasperl
Copy link

kasperl commented Jan 29, 2013

We're not going to implement more timer support for M3.


Removed this from the M3 milestone.
Added this to the M4 milestone.
Changed the title to: "dart2js: timer interface is not supported".

@kasperl
Copy link

kasperl commented Apr 22, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@lrhn
Copy link
Member

lrhn commented Apr 24, 2013

Issue #10109 has been merged into this issue.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed this from the M5 milestone.
Added this to the Later milestone.
Removed TriageForM5 label.

@lrhn
Copy link
Member

lrhn commented May 8, 2014

The d8 preamble now simulates non-zero timers as well.
This code could probably work for jsshell as well, but hasn't been used.
If it can be reused without having to duplicate the same code in two files, it would be preferable.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@karlklose
Copy link
Contributor Author

Working as intended. We can simulate some of their functionality but they are not available on these platforms.

@floitschG
Copy link
Contributor

We could keep this bug, for the jsshell. There are still lots of tests that are marked as failing because of it, and it should be feasible (if not trivial) to adapt the v8 code for jsshell.

@lrhn
Copy link
Member

lrhn commented Dec 8, 2015

I'm pretty sure we can just copy the d8 preamble and use it for jsshell as well. At least the timer code is completely generic.
The reason I haven't done so yet is that that would leave use with no testing setting where timers are not available, so we would never test the "timers not available" code.

@floitschG
Copy link
Contributor

I don't think we need the "timers not available" code tested.
I prefer having jsshell tested.
/cc @sigmundch what do you prefer?

@sigmundch
Copy link
Member

It seems that we can get more value from having jsshell tested, so my preference is towards that too.

Since the extra code lives in a preamble, we could technically also have extra test-only preambles if we want to cover specific error-code functionality. How complex would it be to add a single test that uses a test-specific preamble? Is that worth the effort?

@floitschG
Copy link
Contributor

I don't think it's worth the effort. Our customers run in the browser, and there timers exist.
Furthermore, we can always recommend to use our preambles when running outside the browser.

@sigmundch
Copy link
Member

sgtm

@sigmundch
Copy link
Member

(reopened to track adding timer support in the jsshell preamble, hopefully by simply coping it from the d8 preamble)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants