Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: change JS AST printer to select local renamer dynamically #7614

Closed
rakudrama opened this issue Dec 27, 2012 · 9 comments
Closed

dart2js: change JS AST printer to select local renamer dynamically #7614

rakudrama opened this issue Dec 27, 2012 · 9 comments
Assignees
@rakudrama
Labels
web-dart2js

Comments

@rakudrama
Copy link
Member

The current printer selects local renaming globally for printing.
I'm trying to aggregate functions into a larger JavaScript AST.
The global selection does not suit this - local renaming needs to be selected on a per-function basis within one call to prettyPrint.

An alternative is to ensure that local renaming can always be performed.
@kasperl
Copy link

kasperl commented Jan 7, 2013

Added this to the M3 milestone.

@anders-sandholm
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@kasperl
Copy link

kasperl commented Apr 22, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed this from the M5 milestone.
Added this to the Later milestone.
Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@karlklose
Copy link
Contributor

@rakudrama Is this resolved?

@rakudrama
Copy link
Member Author

Local renaming can always be performed.
We also now aggregate the entire program into a single AST.
There is a feature via a special comment to disable renaming in a given scope.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakudrama rakudrama

Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @rakudrama @kasperl @anders-sandholm @karlklose