Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js: stable order for parallel assignments #7574

Open
rakudrama opened this issue Dec 21, 2012 · 10 comments
Open

dart2js: stable order for parallel assignments #7574

rakudrama opened this issue Dec 21, 2012 · 10 comments
Labels
area-web Issues related to Dart Web. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@rakudrama
Copy link
Member

The SSA graph deserialization is unstable.

For example, r and i are swapped in declaration and initialization order:

swarm r16448:
$$.Decoder = {"":"Object;index,data",
 readInt$0: function() {
  var t1, t2, i, r, t3, v;
  for (t1 = this.data, t2 = $.getInterceptor$JSString(t1), i = 0, r = 0; true; ++i) {

swarm r16453:
$$.Decoder = {"":"Object;index,data",
 readInt$0: function() {
  var t1, t2, r, i, t3, v;
  for (t1 = this.data, t2 = $.getInterceptor$JSString(t1), r = 0, i = 0; true; ++i) {

@rakudrama
Copy link
Member Author

Marked this as blocking #2388.

@kasperl
Copy link

kasperl commented Jan 7, 2013

Added this to the M3 milestone.

@rakudrama
Copy link
Member Author

An easy way to repro this is to change elements/modelx.dart:

class ElementX implements Element {
  ...
  final int hashCode = ++elementHashCode;

to

  final int hashCode = 7^++elementHashCode;

and compare before-and-after outputs.


Set owner to ngeoffray@google.com.

@DartBot
Copy link

DartBot commented Feb 19, 2013

This comment was originally written by ngeoffray@google.com


Removed this from the M3 milestone.
Added this to the M4 milestone.

@kasperl
Copy link

kasperl commented Apr 22, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed this from the M5 milestone.
Added this to the Later milestone.
Removed TriageForM5 label.

@DartBot
Copy link

DartBot commented Dec 19, 2013

This comment was originally written by ngeoffray@google.com


Set owner to @floitschG.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@floitschG floitschG removed their assignment Aug 11, 2017
@vsmenon vsmenon added the area-web Issues related to Dart Web. label Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Issues related to Dart Web. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

6 participants