Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strange error (bad HTTP request) from invalid pubspec.yaml #7466

Closed
jmesserly opened this issue Dec 17, 2012 · 6 comments
Closed

strange error (bad HTTP request) from invalid pubspec.yaml #7466

jmesserly opened this issue Dec 17, 2012 · 6 comments
Assignees
@munificent
Milestone
M4

Comments

@jmesserly
Copy link

if I run "pub install" on this pubspec.yaml:

{
  "name": "web_ui",
  "author": "Web UI Authors <web-ui@dartlang.org>",
  "homepage": "https://github.com/dart-lang/web-ui",
  "description": "An easy way to build web apps in Dart.",
  "version": "0.2.9",
  "dependencies": {
    /* this is a comment */
    "args": "any",
    "html5lib": ">=0.2.1+1 <0.2.2",
    "js": "any",
    "logging": "any",
    "unittest": "any"
  }
}

the error I got was:
HTTP error 400: Bad Request
@munificent
Copy link
Member

Added this to the M3 milestone.

@munificent
Copy link
Member

My guess is that "/* ... " is getting parsed as a string in YAML, so it thinks it's a package name. Then when we try to find that, it fails horribly. We should handle this better.

@munificent
Copy link
Member

Removed this from the M3 milestone.
Added this to the M4 milestone.

@munificent
Copy link
Member

Set owner to @munificent.
Added Started label.

@munificent
Copy link
Member

Package names are now URL-encoded. We don't catch this at parse time, but now you'll get:

Package "/* ... */" could not be found.

which should tip you off as to the problem.

Added Fixed label.

@jmesserly jmesserly added this to the M4 milestone Feb 21, 2013
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#386.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
None yet
Projects
None yet
Milestone
M4
Development

No branches or pull requests
3 participants
@munificent @jmesserly @DartBot