Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date_time_format_file_even_test.dart fails on Mac OS X when run in test harness #7194

Open
ghost opened this issue Dec 6, 2012 · 4 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@ghost
Copy link

ghost commented Dec 6, 2012

Failure occurs only when run from within the test harness.

./tools/test.py -> 2 failures
./tools/test.py pkg -> no failures

stdout:
unittest-suite-wait-for-done
FAIL: Run all date formatting tests with locales from files
  Caught Illegal argument(s)
  #­0 _JSSyntaxRegExp._ExecuteMatch (dart:core-patch:1377:1)
  #­1 _JSSyntaxRegExp.hasMatch (dart:core-patch:1362:31)
  #­2 dataDirectory (file:///sources/boxerdart/dart/pkg/intl/test/data_directory.dart:18:43)
  #­3 runEverything.<anonymous closure> (file:///sources/boxerdart/dart/pkg/intl/test/date_time_format_file_test_stub.dart:30:52)
  #­4 Collections.map (dart:collection:104:24)
  #­5 List.map (dart:core-patch:290:27)
  #­6 runEverything (file:///sources/boxerdart/dart/pkg/intl/test/date_time_format_file_test_stub.dart:29:55)
  #­7 runWith.<anonymous closure>.<anonymous closure> (file:///sources/boxerdart/dart/pkg/intl/test/date_time_format_file_test_stub.dart:23:42)
  #­8 _SpreadArgsHelper.invoke1.invoke1.<anonymous closure> (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:434:29)
  #­9 guardAsync (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:766:19)
  

0 PASSED, 1 FAILED, 0 ERRORS

stderr:
Unhandled exception:
Exception: Some tests failed.

­0 Configuration.onDone (file:///sources/boxerdart/dart/pkg/unittest/lib/src/config.dart:130:7)

­1 _completeTests (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:835:17)

­2 _nextBatch._nextBatch (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:818:17)

­3 _nextTestCase (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:678:14)

­4 _registerException (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:794:18)

­5 guardAsync (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:768:23)

­6 _SpreadArgsHelper.invoke1.invoke1 (file:///sources/boxerdart/dart/pkg/unittest/lib/unittest.dart:430:22)

­7 _FutureImpl._complete (bootstrap:840:19)

­8 _FutureImpl._complete (bootstrap:848:5)

­9 _FutureImpl._setValue (bootstrap:862:14)

­10 _CompleterImpl.complete (bootstrap:949:26)

­11 Futures.wait.<anonymous closure> (bootstrap:725:29)

­12 _FutureImpl._complete (bootstrap:840:19)

­13 _FutureImpl._complete (bootstrap:848:5)

­14 _FutureImpl._setValue (bootstrap:862:14)

­15 _CompleterImpl.complete (bootstrap:949:26)

­16 _FutureImpl.transform.<anonymous closure> (bootstrap:887:25)

­17 _FutureImpl._complete (bootstrap:840:19)

­18 _FutureImpl._complete (bootstrap:848:5)

­19 _FutureImpl._setValue (bootstrap:862:14)

­20 _CompleterImpl.complete (bootstrap:949:26)

­21 _FutureImpl.transform.<anonymous closure> (bootstrap:887:25)

­22 _FutureImpl._complete (bootstrap:840:19)

­23 _FutureImpl._complete (bootstrap:848:5)

­24 _FutureImpl._setValue (bootstrap:862:14)

­25 _CompleterImpl.complete (bootstrap:949:26)

­26 _FutureImpl.transform.<anonymous closure> (bootstrap:887:25)

­27 _FutureImpl._complete (bootstrap:840:19)

­28 _FutureImpl._complete (bootstrap:848:5)

­29 _FutureImpl._setValue (bootstrap:862:14)

­30 _CompleterImpl.complete (bootstrap:949:26)

­31 _File.readAsBytes.<anonymous closure> (dart:io:1281:25)

­32 _BaseDataInputStream._checkScheduleCallbacks.issueCloseCallback (dart:io:6446:59)

­33 _Timer._createTimerHandler._handleTimeout (dart:io:7019:28)

­34 _Timer._createTimerHandler._handleTimeout (dart:io:7027:7)

­35 _Timer._createTimerHandler.<anonymous closure> (dart:io:7035:23)

­36 _ReceivePortImpl._handleMessage (dart:isolate-patch:37:92)

@ghost
Copy link
Author

ghost commented Dec 6, 2012

Removed the owner.

@alan-knight
Copy link
Contributor

This doesn't reproduce for me. I've run it quite a few times and had no failures at all, either debug or release mode. Illegal argument to a RegExp seems like a very peculiar error to get based on running a subset of tests versus the entire suite.

@ghost
Copy link
Author

ghost commented Dec 7, 2012

Alan has tested it on a Macbook Pro which has less parallelism available than my Mac Pro. The issue is caused by too many open files. By default, Mac OS X allows 256 open files. The test pass once I increase that file limit, e.g., ulimit -n 1024

@ricowind
Copy link
Contributor

srdjan: If this is not an issue with the testing framework, but rather with the (very low) file descriptor limit on mac can we please close this?

@ghost ghost added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Nov 25, 2013
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants