Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js --minify affects default toString method and type instances #7179

Closed
ErikCorryGoogle opened this issue Dec 6, 2012 · 6 comments
Closed

dart2js --minify affects default toString method and type instances #7179

ErikCorryGoogle opened this issue Dec 6, 2012 · 6 comments
Labels
web-dart2js

Comments

@ErikCorryGoogle
Copy link
Contributor

The minifier renames classes, which is visible to the program
@kasperl
Copy link

kasperl commented Dec 6, 2012

I guess this is something you want to fix so that the minifier does not affect these things?

Added this to the Later milestone.
Added Area-Dart2JS, Triaged labels.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed the owner.
Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sigmundch
Copy link
Member

We actually are not planing to fix this issue. We need to be clear in explaining that minified names may become obfuscated, but that is a common expectation our users have. If fact, class names and other symbols in the program are often sensitive information and users prefer to have these names stripped out when minify is turned on.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @sigmundch @kasperl @ErikCorryGoogle