Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart_NewStringFromUTF16 and Dart_NewStringFromUTF32 should check for valid input #7046

Open
a-siva opened this issue Nov 30, 2012 · 2 comments
Open

Dart_NewStringFromUTF16 and Dart_NewStringFromUTF32 should check for valid input #7046

a-siva opened this issue Nov 30, 2012 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug

Comments

@a-siva
Copy link
Contributor

a-siva commented Nov 30, 2012 •
edited by zanderso

Dart_NewStringFromUTF16 should ensure that the input utf16_array
consists of valid values similar to how Dart_NewStringFromUTF8 validates
the input.
@lexprfuncall
Copy link

The UTF-16 validity check should exclude unpaired lead and trail surrogates. The UTF-32 validity check should reject these values outright, whether paired or not.

There are other classes of characters which might be worthwhile excluding. However, this seems like a reasonable starting point.

@iposva-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Unassigned label.

@a-siva a-siva added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jun 5, 2013
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@zanderso zanderso added type-enhancement A request for a change that isn't a bug and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 5, 2017
@askeksa-google askeksa-google mentioned this issue Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @lexprfuncall @iposva-google @zanderso @a-siva