Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The utf library's stringToCharCodes should avoid extra allocation for BMP-strings. #6553

Closed
lrhn opened this issue Nov 6, 2012 · 0 comments
Closed

The utf library's stringToCharCodes should avoid extra allocation for BMP-strings. #6553

lrhn opened this issue Nov 6, 2012 · 0 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@lrhn
Copy link
Member

lrhn commented Nov 6, 2012

If a string contains no surrogates (i.e., it's entirely in the BMP), the result of stringToCharCodes(string) is the same as string,charCodes
(where charCodes should probably be renamed to codeUnits with the 16-bit strings).
The function should recognize this and simply return a thin unmodifiable List wrapper around the String.
@lrhn lrhn added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Nov 6, 2012
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@lrhn lrhn added the core-m label Aug 11, 2017
@floitschG floitschG added closed-obsolete Closed as the reported issue is no longer relevant and removed core-m labels Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @lrhn @floitschG