Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --use-sdk in test.dart to skip some test selectors #6545

Closed
munificent opened this issue Nov 5, 2012 · 2 comments
Closed

Use --use-sdk in test.dart to skip some test selectors #6545

munificent opened this issue Nov 5, 2012 · 2 comments
Assignees
@peter-ahe-google
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@munificent
Copy link
Member

This morning, we talked about adding support to test.dart for having some test selectors get skipped if --use-sdk is false. This is relevant because we have a pub test we want to include that relies on the SDK:

https://codereview.chromium.org/11187011/

This patch got reverted because it breaks the VM bots.

If I remember right, what we discussed was the pub tests would only run if --use-sdk is passed. That means the VM bots and people running tests locally without the SDK will skip them, but the pub bots will pass that in to run the tests. It also means we can leave pub in the default selector set.

Do I remember that right? If so, this is a tracking bug to add support to test.dart for that. Thanks!
@peter-ahe-google
Copy link
Contributor

Actually, after having the idea mature in my head, I think the best option is to add $use_sdk boolean to the status file expressions. But the effect will be the same: you can express that certain tests require the SDK.

@munificent
Copy link
Member Author

That works too, but that isn't actually what I want to express.

My goal is to remove the "pub" and "pkg" tests from the VM bots. There are pub bots dedicated to running those tests, so running them on the VM bots is redundant. It is also that one of the motivations for removing them from the VM bots is because one pub test will require the SDK, but my goal is not to just disable one pub test (and presumably none of the pkg tests) from the VM bots. I want to disable all of them, even though many of them would run fine.

How do you recommend I go about this?

I'd like a solution that requires a minimum of discussion since we have a minimum 24 hour delay between any exchange and November is moving surprisingly quickly.

@munificent munificent added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Nov 9, 2012
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@munificent munificent added the closed-obsolete Closed as the reported issue is no longer relevant label Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @munificent @peter-ahe-google