Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should be using OS::Print and OS::PrintErr instead of print and fprintf(stderr in the VM #6509

Closed
gramster opened this issue Nov 2, 2012 · 4 comments
Closed

We should be using OS::Print and OS::PrintErr instead of print and fprintf(stderr in the VM #6509

gramster opened this issue Nov 2, 2012 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@gramster
Copy link
Contributor

gramster commented Nov 2, 2012

If we want to host the VM on embedded platforms like Android, we need to redirect error messages somewhere useful like the logs. The obvious way to do this is by using the OS::Print and OS::PrintErr functions instead, which we can have do useful platform-specific behavior.
@iposva-google
Copy link
Contributor

Gram, please point out the printf and fprintf in the core VM which are in your way? I found two in dart_api_impl.cc which should be easy for you to submit patches for.

Added Triaged label.

@gramster
Copy link
Contributor Author

gramster commented Nov 5, 2012

Well, there is the general question of whether all printfs should be replaced with something that can be adjusted on a per-platform basis. That would seem to make sense to me, as at least theoretically there could be platforms where printf is not allowed or causes issues.

I did change a bunch of these myself to move forward and I'll clean that up a bit and upload a CL; you can take a look at that and see which you agree with or not.

@iposva-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Unassigned label.

@gramster gramster added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jun 5, 2013
@iposva-google
Copy link
Contributor

Stale.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @gramster @iposva-google