Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM requires special flags to achieve best compile-time performance for dart2js #6495

Closed
peter-ahe-google opened this issue Nov 2, 2012 · 7 comments
Closed

VM requires special flags to achieve best compile-time performance for dart2js #6495

peter-ahe-google opened this issue Nov 2, 2012 · 7 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@peter-ahe-google
Copy link
Contributor

Currently, dart2js is passing two flags to the VM:

--heap_growth_rate=32
--no_use_inlining

I think everyone agrees that this is a short-term solution, and this bug is to track this issue.

We can remove these options when this command is faster without the options:

dart sdk/lib/_internal/compiler/implementation/dart2js.dart samples/swarm/swarm.dart
@peter-ahe-google
Copy link
Contributor Author

cc @kasperl.

@ghost
Copy link

ghost commented Nov 2, 2012

Current performance difference (on Z620):
./out/ReleaseIA32/dart sdk/lib/_internal/compiler/implementation/dart2js.dart samples/swarm/swarm.dart

--no_use_inlining: 9.5 sec -> 8 sec
--heap_growth_rate=32: 8.0 sec -> 7 sec

@peter-ahe-google
Copy link
Contributor Author

FWIW, I'm currently investigating using --heap_growth_rate=512, but I am also investigating options for decreasing memory usage. However, by its nature, dart2js requires a lot of memory. Using 512 instead of 32 saves me almost 10% on compile-time when self-hosting.

@iposva-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Unassigned label.

@kasperl
Copy link

kasperl commented Jun 28, 2013

FWIW, we're still passing --heap_growth_rate=512 because it makes dart2js a lot faster, but we'd really like to get to a point where we wouldn't have to do that.

cc @iposva-google.

@ghost
Copy link

ghost commented Jun 28, 2013

The performance difference with/without the flag is about 10% (tested on Hello.dart, swarm and dummy_compiler_test).

@ghost
Copy link

ghost commented Oct 17, 2014

Last measured performance improvement through --heap_growth_rate=512 is 2.5% (dart2js compiling itself). I assume this bug can be closed, please reopen if you disagree.

Added Fixed label.

@peter-ahe-google peter-ahe-google added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Oct 17, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kasperl @iposva-google @peter-ahe-google