Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to host package #6347

Closed
DartBot opened this issue Oct 28, 2012 · 7 comments
Closed

Request to host package #6347

DartBot opened this issue Oct 28, 2012 · 7 comments
Assignees
Milestone

Comments

@DartBot
Copy link

DartBot commented Oct 28, 2012

This issue was originally filed by chri...@gmail.com


https://github.com/eee-c/hipster-mvc

@sethladd
Copy link
Contributor

Removed Type-Defect label.
Added Type-Task, Area-Pub, Triaged labels.

@nex3
Copy link
Member

nex3 commented Oct 29, 2012

"lib/main.dart" doesn't seem to do anything and should probably be removed.

Your package should follow the package naming conventions (http://pub.dartlang.org/doc/pubspec.html#name), which means its name should be a valid Dart identifier such as "hipster_mvc". It's also recommended, but not required, that your libraries have names that are valid Dart identifiers.


Set owner to @nex3.
Added this to the M2 milestone.
Added Waiting label.

@DartBot
Copy link
Author

DartBot commented Oct 29, 2012

This comment was originally written by chris.ee...@gmail.com


Renamed the package in pubspec to hipster_mvc. Removed "lib/main.dart" -- you are correct, it was not used.

By library names, do you mean the filenames in lib? I rather like the import filename being the same as the imported class, e.g.

#import('package:hipster-mvc/HipsterCollection.dart');
class Comics extends HipsterCollection { /* ... */ }

If it's something else, I'd definitely consider a change.

@nex3
Copy link
Member

nex3 commented Oct 30, 2012

It's not a requirement, but the convention for most packages so far has been to have the library names be lower case and underscored rather than camel cased.

@DartBot
Copy link
Author

DartBot commented Oct 30, 2012

This comment was originally written by chri...@gmail.com


OK. Happy to conform to the convention. I updated the files in the repo. Let me know if anything else needs doing.

@nex3
Copy link
Member

nex3 commented Oct 30, 2012

Uploaded: http://pub.dartlang.org/packages/hipster_mvc


Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#253.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants