-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to host package #6347
Comments
Removed Type-Defect label. |
"lib/main.dart" doesn't seem to do anything and should probably be removed. Your package should follow the package naming conventions (http://pub.dartlang.org/doc/pubspec.html#name), which means its name should be a valid Dart identifier such as "hipster_mvc". It's also recommended, but not required, that your libraries have names that are valid Dart identifiers. Set owner to @nex3. |
This comment was originally written by chris.ee...@gmail.com Renamed the package in pubspec to hipster_mvc. Removed "lib/main.dart" -- you are correct, it was not used. By library names, do you mean the filenames in lib? I rather like the import filename being the same as the imported class, e.g. #import('package:hipster-mvc/HipsterCollection.dart'); If it's something else, I'd definitely consider a change. |
It's not a requirement, but the convention for most packages so far has been to have the library names be lower case and underscored rather than camel cased. |
This comment was originally written by chri...@gmail.com OK. Happy to conform to the convention. I updated the files in the repo. Let me know if anything else needs doing. |
Uploaded: http://pub.dartlang.org/packages/hipster_mvc Added Fixed label. |
This issue has been moved to dart-lang/pub#253. |
This issue was originally filed by chri...@gmail.com
https://github.com/eee-c/hipster-mvc
The text was updated successfully, but these errors were encountered: