Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub error messages should include more context #5971

Closed
jmesserly opened this issue Oct 17, 2012 · 12 comments
Closed

pub error messages should include more context #5971

jmesserly opened this issue Oct 17, 2012 · 12 comments
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@jmesserly
Copy link

We got a bug report with an error:

    Running pub update fails on web-components with the following message:

    Package 'js' is depended on from both sources 'hosted' and 'git'.

I suspect the underlying bug was already fixed. But, it would be nice if the error message had printed more context. For example, which pubspec.yaml referred to it as "git" and which was "hosted"? We need something like a "stack trace" of dependencies to help users track down this kind of bug.

https://github.com/dart-lang/dart-web-components/issues/86

@DartBot
Copy link

DartBot commented Oct 21, 2012

This comment was originally written by jvande...@gmail.com


I am still seeing this issue. I am running Version 0.1.6.r0013679, build 13679. The error does seem to indicate that there is something wrong with some packages dependency configuration.

If that is the case I think the request is simply for a more clear error.

@DartBot
Copy link

DartBot commented Oct 21, 2012

This comment was originally written by jvande...@gmail.com


Also this is what my project pub spec looks like.

name: 'Project'
dependencies:
  JsonObject:
    git: https://github.com/chrisbu/dartwatch-JsonObject.git
  web_components:
    git: https://github.com/dart-lang/dart-web-components
  google_maps:
    git: https://github.com/a14n/dart-google-maps.git

@jmesserly
Copy link
Author

Ah. I think what happened here is the version of "js" on google_maps used to be a "git" URL, whereas "web_components" used a hosted URL. I now get a slightly more sensible error:

Package 'js' has disjoint constraints.

@jmesserly
Copy link
Author

also, the error messages could still be better :)

it would be nice if, e.g. it printed what the disjoint constraints are and which pubspec's they came from

@jmesserly
Copy link
Author

FYI, web_components now accepts "any" JS interop version

@munificent
Copy link
Member

Added this to the M2 milestone.

@munificent
Copy link
Member

Yeah, we should definitely be more helpful here.

@munificent
Copy link
Member

Added Started label.

@munificent
Copy link
Member

Added Fixed label.

@munificent
Copy link
Member

Issue #7139 has been merged into this issue.

@munificent
Copy link
Member

Issue #7127 has been merged into this issue.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#216.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants