Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do some validation of packages in the system cache #5939

Closed
munificent opened this issue Oct 16, 2012 · 8 comments
Closed

Do some validation of packages in the system cache #5939

munificent opened this issue Oct 16, 2012 · 8 comments
Assignees
@munificent
Milestone
M3

Comments

@munificent
Copy link
Member

Previously, there was an issue where pub could end up with an empty directory in the system cache. That would lead it to think the package had been successfully cached but was empty, which caused those "doesn't have a pubspec.yaml" errors people were/are seeing.

The root cause of that bug has been fixed, but:

  1. Some people may still have existing broken system caches from before this fix.
  2. There may be other unknown ways that a package could broken in your cache.

Given that, it might be good to do some validation of packages in the cache at pub install/update time. If the package isn't valid, we'll blow it away and install it again. Trivial validation would be if the directory is empty, it's bad, but we could possibly do more than that.

I still think prevention is better than a cure, and we should be in better shape for that now that pub downloads packages to a temp directory, but this is worth keeping in mind if we see other issues here.
@dgrove
Copy link
Contributor

dgrove commented Oct 16, 2012

What about computing an MD5 over the directory, and recording that as part of the pub upload process?

@munificent
Copy link
Member Author

Right. That's one of the things we discussed. The challenge I see with that is that then validating that MD5 hash means walking the entire directory, which might be too costly to do every time you pub install.

@munificent
Copy link
Member Author

Removed this from the Later milestone.
Added this to the M3 milestone.

@munificent
Copy link
Member Author

Set owner to @munificent.
Added Started label.

@munificent
Copy link
Member Author

Added Accepted label.

@munificent
Copy link
Member Author

Added Started label.

@munificent
Copy link
Member Author

pub install will now re-install a previously cached package if it sees that the cached directory is missing a pubspec or has an empty lib directory.

Added Fixed label.

@munificent munificent self-assigned this Feb 13, 2013
@munificent munificent added this to the M3 milestone Feb 13, 2013
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#206.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
None yet
Projects
None yet
Milestone
M3
Development

No branches or pull requests
3 participants
@munificent @dgrove @DartBot