No warning when abstract class from imported library is also declared in file #5871
Comments
|
I believe that this is working as expected. According to the specification (in the section on handling import directives): Then, for each entry mapping key k to declaration d in NS, d is made available in the top level scope of L under the name k unless either: If I'm understanding this correctly, this means that it's OK (there shouldn't be a warning or error) for a library L to declare a name that is also declared in an imported library. The rationale is that adding a new name to an imported library is less likely to break the importing library. That said, I think it would be a good idea for us to offer an option to generate a "warning" in this case. Set owner to @bwilkerson. |
|
Added Analyzer-Hint label. |
|
Removed this from the Later milestone. |
|
Removed Oldschool-Milestone-Later label. |
sethladd
added
Type-Enhancement
area-analyzer
kevmoo
added
P2
|
We have improved the error message, so hopefully the UX is better now. Closing as stale. |
Consider this code:
import 'dart:html';
var screens = new Map<String, Screen>();
addScreen(String name) {
screens[name] = new Screen();
}
Screen returnScreen(String name) {
return screens[name];
}
class Screen {
}
main() {
addScreen("foo");
var s = returnScreen("foo");
print(s.runtimeType);
}
When you run it, you get this error:
Exception: type 'Screen' is not a subtype of type 'Screen' of 'function result'.
Stack Trace: #0 returnScreen (http://127.0.0.1:3030/Users/sethladd/dart/dupehtmlclassname/dupehtmlclassname.dart:13:17)
1 main (http://127.0.0.1:3030/Users/sethladd/dart/dupehtmlclassname/dupehtmlclassname.dart:22:23)
There is an abstract class named Screen in dart:html.
I would expect some sort of warning from the Editor when I declared a class named Screen.
The text was updated successfully, but these errors were encountered: