Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test: Bad error-message for missing closing parenthesis #5829

Closed
floitschG opened this issue Oct 12, 2012 · 20 comments
Closed

Missing test: Bad error-message for missing closing parenthesis #5829

floitschG opened this issue Oct 12, 2012 · 20 comments
Assignees

Comments

@floitschG
Copy link
Contributor

Getting an "unexpected token 'EOF'" for the following dart code:

foo(x { // <= missing closing ")"
  return x;
}

@kasperl
Copy link

kasperl commented Oct 12, 2012

Added this to the M2 milestone.

@peter-ahe-google
Copy link
Contributor

Fixed in https://codereview.chromium.org/11092101/.

I'm keeping this bug open to remind myself to write a test of this.


Set owner to @peter-ahe-google.
Added Started label.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the M2 milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed Priority-Medium label.
Added Priority-High label.

@peter-ahe-google
Copy link
Contributor

Test added in r14338.


Added Fixed label.

@peter-ahe-google
Copy link
Contributor

Actually, I never landed CL 11092101.


Added Started label.

@peter-ahe-google
Copy link
Contributor

So naturally the test I added in r14338 isn't worth the bits it is printed on.

@peter-ahe-google
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the M3 milestone.

@peter-ahe-google
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@kasperl
Copy link

kasperl commented Apr 22, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed this from the M5 milestone.
Added this to the Later milestone.
Removed TriageForM5 label.

@peter-ahe-google
Copy link
Contributor

Removed Priority-High label.
Added Priority-Medium label.

@peter-ahe-google
Copy link
Contributor

Changed the title to: "Missing test: Bad error-message for missing closing parenthesis".

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@srawlins
Copy link
Member

I think this can be closed. There are UNMATCHED_TOKEN tests in sdk/lib/_internal/compiler/implementation/warnings.dart . The error from dart2js looks good:

$ dart2js issue-5829.dart
issue-5829.dart:5:4:
Error: Can't find ')' to match '('.
foo(x { // <= missing closing ")"
   ^
Error: Compilation failed.

@floitschG
Copy link
Contributor Author

Thanks.

Fix seems to have been committed with r15386.


Added Fixed label.

@karlklose
Copy link
Contributor

Verified fixed in 79a8654

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants