Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export_test, export_cyclic_test and generic_creation_test all new failures #5785

Closed
efortuna opened this issue Oct 10, 2012 · 8 comments
Closed

export_test, export_cyclic_test and generic_creation_test all new failures #5785

efortuna opened this issue Oct 10, 2012 · 8 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@efortuna
Copy link
Contributor

As of r13478 ("Added support for exports and re-exports."), export_test, export_cyclic_test, and generic_creation_test all started failing. We need to investigate and fix this.
@johnniwinther
Copy link
Member

This is probably caused by #­2264.

@kasperl
Copy link

kasperl commented Oct 11, 2012

This is a test issue. The tests use the new library syntax (not #library) and the test framework doesn't seem to like that. Not sure if this is an M1 issue or not so marking it as "later" for now.

cc @johnniwinther.
Removed the owner.
Removed this from the M1 milestone.
Added this to the Later milestone.
Removed Area-Dart2JS label.
Added Area-Test label.

@DartBot
Copy link

DartBot commented Oct 11, 2012

This comment was originally written by antonm@google.com

Issue #5777 has been merged into this issue.

@gramster
Copy link
Contributor

I have an in progress CL which should address this.

@ricowind
Copy link
Contributor

gram@ Did that cl land?

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@efortuna efortuna added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 4, 2014
@srawlins
Copy link
Member

This can be closed. These tests are no longer failing.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@bkonyi bkonyi closed this as completed Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@kevmoo @srawlins @efortuna @kasperl @gramster @ricowind @DartBot @johnniwinther @bkonyi