eliminate checked-in generated files #568

dgrove · 2011-11-23T04:19:01Z

One thing we learned during today's breakage is that we need to make all generation of dart code part of the build process. These files are checked in auto-generated - can you please either remove these files or move their generation into the standard build process?

dart/client/html/html.dart:// Auto-generated Dart HTML library.
dart/client/html/release/html.dart:// Auto-generated Dart HTML library.

dgrove · 2011-11-23T04:20:11Z

Mark is priority high as we need to improve the build process.

Removed Priority-Medium label.
Added Priority-High label.

DartBot · 2011-11-24T02:58:34Z

This comment was originally written by drfibonacci@google.com

Added Triaged label.

dgrove · 2011-12-20T18:41:50Z

Hi Jacob- can you please give let us know when this can be addressed?

iposva-google · 2012-01-12T23:05:26Z

This keeps causing problems, what is the ETA for this to be addressed?

cc @dgrove.
cc @gbracha.
Removed Priority-High label.
Added Priority-Critical label.

vsmenon · 2012-01-12T23:32:14Z

Some thoughts. Keep in mind that one problem is that the IDL these scripts use are in the WebKit repo, interspersed with WebKit Source.

(1) Pull WebKit/Source/WebCore into third_party for a regular Dart checkout. This is roughly 7700 files of which ~550 are IDL files. We should be able to cut this down further by pulling in just the subdirs of WebCore that contain IDL (though even those are mixed IDL and C++ code).

(2) Check in copies of IDL periodically into our repo and use those to generate. We'll need to check whether there are licensing issues with this. The IDL files have differing licenses on them, so we'll need to look at all the variants.

(3) Continue checking in generated files. I'm skeptical generating these on build will improve the build process. E.g., add another function to the core Collection type will still require hacking the scripts that auto-gen subclasses.

dgrove · 2012-01-13T04:14:29Z

One note on #2 - we could certainly put IDL files into third party and be not have a license problem.

Also, an intermediate step here might be for there to be clear directions on how to regen the files, and a link from each file to its regen instructions.

vsmenon · 2012-02-27T17:26:07Z

Jacob, any update on this? My understanding is that all the scripts needed to generate html.dart are now checked in.

I suggest we do Dan's intermediate step as step #1 here and then lower the priority from Critical.

iposva-google · 2012-03-09T18:20:59Z

I am doing an integration now and the majority of the files are all generated. When will this be fixed?

vsmenon · 2012-03-26T16:55:16Z

Lowering as the vast majority of files are no longer checked in.

Set owner to @vsmenon.
Removed Priority-Critical label.
Added Priority-Medium label.

vsmenon · 2012-04-12T20:49:08Z

Removed Area-UI label.
Added Area-DOM label.

vsmenon · 2012-06-22T17:22:53Z

Added this to the Later milestone.

iposva-google · 2012-08-13T20:11:38Z

Removed Area-DOM label.
Added Area-HTML label.

vsmenon · 2012-08-17T01:24:18Z

Removed the owner.

efortuna · 2013-08-26T20:56:27Z

Added blink_idl label.

kevmoo · 2014-04-07T19:49:42Z

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

kasperl · 2014-07-10T10:22:53Z

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

efortuna · 2014-08-01T16:59:07Z

Removed Priority-Medium, Oldschool-Milestone-Later labels.
Added Priority-Low label.

…mime, protobuf, pub_semver, sse, string_scanner, term_glyph, test, test_reflective_loader, typed_data, vector_math, web, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. browser_launcher (https://github.com/dart-lang/browser_launcher/compare/f60df1d..c68ec25): c68ec25 2023-12-04 Kevin Moore drop outdated lints ecosystem (https://github.com/dart-lang/ecosystem/compare/805ab4f..79a1bc5): 79a1bc5 2023-12-01 dependabot[bot] Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#204) c51c500 2023-12-01 dependabot[bot] Bump actions/github-script (#202) 64eeeee 2023-12-01 dependabot[bot] Bump peter-evans/create-or-update-comment (#203) 32461a7 2023-12-01 Moritz Upgrades to `health.yaml` (#201) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/2238a6b..ae48489): ae48489 2023-12-02 dependabot[bot] Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#61) markdown (https://github.com/dart-lang/markdown/compare/3774ad0..d2e7903): d2e7903 2023-12-01 dependabot[bot] Bump subosito/flutter-action from 2.11.0 to 2.12.0 (#569) 42d32cb 2023-11-30 Kevin Moore Update to latest lints, require Dart ^3.1 (#568) mime (https://github.com/dart-lang/mime/compare/8ebf946..56359b0): 56359b0 2023-12-05 Yoshihiro Tanaka Detect HEIC/HEIF format by checking header bytes (#109) protobuf (https://github.com/dart-lang/protobuf/compare/dcec2ed..bb19774): bb19774 2023-11-29 Ömer Sinan Ağacan Revert `PbMap._wrappedMap` empty map value (#904) cf43230 2023-11-23 Ömer Sinan Ağacan Update getList and getMap return types (#903) 4e0bdff 2023-11-23 Ömer Sinan Ağacan Make wrapped lists in PbList monomorphic (#902) pub_semver (https://github.com/dart-lang/pub_semver/compare/f9e94ee..4572181): 4572181 2023-12-04 Kevin Moore drop outdated lints (#96) sse (https://github.com/dart-lang/sse/compare/1df63f2..8d2e2f0): 8d2e2f0 2023-12-01 dependabot[bot] Bump nanasess/setup-chromedriver (#99) c6501b3 2023-12-01 Kevin Moore Drop unneeded dep on pkg:test (#98) string_scanner (https://github.com/dart-lang/string_scanner/compare/a7105ef..ebc30a3): ebc30a3 2023-12-04 Kevin Moore Update to latest lints and cleanup (#67) term_glyph (https://github.com/dart-lang/term_glyph/compare/7c1eb9d..4c5a496): 4c5a496 2023-12-04 Kevin Moore drop outdated lints (#46) test (https://github.com/dart-lang/test/compare/a0a4d1e..9fffb48): 9fffb489 2023-12-01 dependabot[bot] Bump github/codeql-action from 2.22.5 to 2.22.8 (#2145) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/17d40bb..6edf535): 6edf535 2023-11-30 Kevin Moore Update lints, bump min SDK to ^3.1.0 (#56) typed_data (https://github.com/dart-lang/typed_data/compare/0b16bd2..6f6d81d): 6f6d81d 2023-12-04 Kevin Moore drop outdated lints (#78) vector_math (https://github.com/google/vector_math.dart/compare/cca3cf1..38a00c3): 38a00c3 2023-12-04 Kevin Moore Update to latest lints and cleanup (#309) cedd304 2023-12-04 dependabot[bot] Bump actions/checkout from 4.1.0 to 4.1.1 (#307) web (https://github.com/dart-lang/web/compare/cffc2e3..865aeaf): 865aeaf 2023-12-01 Devon Carew update the CI workflow to test the generation script (#112) webdriver (https://github.com/google/webdriver.dart/compare/43ed1db..2c1b6f8): 2c1b6f8 2023-12-01 dependabot[bot] Bump nanasess/setup-chromedriver (#290) dc988d7 2023-12-01 Devon Carew update to the latest package:lints (#291) Change-Id: I2d898b6d772925146630777ef587d29a05288a3b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339720 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>

dgrove added Type-Defect P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Aug 1, 2014

mit-mit removed the blink_idl label Sep 2, 2015

kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016

vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019

This was referenced Oct 29, 2020

DDC stack frames read "new" with no class attached #43970

Open

DDC stack frames read "new" with no class attached #43971

Closed

DDC produces constructor invocation stack frames without class #44066

Closed

This was referenced Nov 5, 2020

Sometimes DDC outputs stack frames in the stack for constructor calls with just "new" and no class information. #44076

Closed

Sometimes DDC outputs stack frames in the stack for constructor calls with just "new" and no class information. #44077

Open

sigmundch closed this as completed Sep 24, 2021

sigmundch added the closed-obsolete Closed as the reported issue is no longer relevant label Sep 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eliminate checked-in generated files #568

eliminate checked-in generated files #568

dgrove commented Nov 23, 2011

dgrove commented Nov 23, 2011

DartBot commented Nov 24, 2011

dgrove commented Dec 20, 2011

iposva-google commented Jan 12, 2012

vsmenon commented Jan 12, 2012

dgrove commented Jan 13, 2012

vsmenon commented Feb 27, 2012

iposva-google commented Mar 9, 2012

vsmenon commented Mar 26, 2012

vsmenon commented Apr 12, 2012

vsmenon commented Jun 22, 2012

iposva-google commented Aug 13, 2012

vsmenon commented Aug 17, 2012

efortuna commented Aug 26, 2013

kevmoo commented Apr 7, 2014

kasperl commented Jul 10, 2014

efortuna commented Aug 1, 2014

eliminate checked-in generated files #568

eliminate checked-in generated files #568

Comments

dgrove commented Nov 23, 2011

dgrove commented Nov 23, 2011

DartBot commented Nov 24, 2011

dgrove commented Dec 20, 2011

iposva-google commented Jan 12, 2012

vsmenon commented Jan 12, 2012

dgrove commented Jan 13, 2012

vsmenon commented Feb 27, 2012

iposva-google commented Mar 9, 2012

vsmenon commented Mar 26, 2012

vsmenon commented Apr 12, 2012

vsmenon commented Jun 22, 2012

iposva-google commented Aug 13, 2012

vsmenon commented Aug 17, 2012

efortuna commented Aug 26, 2013

kevmoo commented Apr 7, 2014

kasperl commented Jul 10, 2014

efortuna commented Aug 1, 2014