Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part-of tags and scripts #5648

Closed
peter-ahe-google opened this issue Oct 4, 2012 · 4 comments
Closed

Part-of tags and scripts #5648

peter-ahe-google opened this issue Oct 4, 2012 · 4 comments
Assignees
@gbracha
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@peter-ahe-google
Copy link
Contributor

A script may not have a library name. But a part-of directive must have a name.
@gbracha
Copy link
Contributor

gbracha commented Oct 5, 2012

Yes, I know. So unnamed scripts that are split into parts will cause warnings. That is the current state of play. Not terribly nice, I agree. On the other hand, if you have a large script that needs to be split, I'd argue you should name it.

Added Accepted label.

@peter-ahe-google peter-ahe-google added Type-Defect area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Oct 5, 2012
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@munificent munificent added the closed-obsolete Closed as the reported issue is no longer relevant label Dec 17, 2016
@munificent
Copy link
Member

I don't think we have "scripts" anymore?

@lrhn
Copy link
Member

lrhn commented Dec 17, 2016

Just for precision: We do have scripts (a library with a main function), but they don't have any restriction against having a library name, so the problem described here is gone.

@munificent
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbracha gbracha

Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @munificent @gbracha @lrhn @peter-ahe-google