Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart:html needs KeyCodes enumeration #5540

Closed
jmesserly opened this issue Sep 27, 2012 · 5 comments
Closed

dart:html needs KeyCodes enumeration #5540

jmesserly opened this issue Sep 27, 2012 · 5 comments
Assignees
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@jmesserly
Copy link

e.g. KeyCodes.escape. We have one for the names, but I'm not sure about keycodes. e.keyCode seems to be one of the things that's safe to use cross browser.

FYI, I'm filing another issue about general KeyboardEvent issues

@blois
Copy link
Contributor

blois commented Oct 15, 2012

Added this to the M2 milestone.

@efortuna
Copy link
Contributor

efortuna commented Nov 1, 2012

Set owner to @efortuna.
Added Accepted label.

@efortuna
Copy link
Contributor

efortuna commented Nov 2, 2012

Basic Keycode enumeration committed with this CL: https://codereview.chromium.org//11362065

You will note that it is lacking in proper localization support. Patches and/or bugs about specific issues on this are welcome.
More to come in the future!

@efortuna
Copy link
Contributor

efortuna commented Nov 2, 2012

Added Fixed label.

@DartBot
Copy link

DartBot commented Nov 2, 2012

This comment was originally written by jjinu...@gmail.com


Schweet!

@jmesserly jmesserly added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Nov 2, 2012
@jmesserly jmesserly added this to the M2 milestone Nov 2, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

4 participants