Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test on Windows buildbot #5133

Closed
iposva-google opened this issue Sep 13, 2012 · 14 comments
Closed

Flaky test on Windows buildbot #5133

iposva-google opened this issue Sep 13, 2012 · 14 comments
Assignees
Labels
area-vm P3 A lower priority bug or feature request

Comments

@iposva-google
Copy link
Contributor

The tests vm/cc/Sleep and vm/cc/Monitor are flaky on the Windows debug buildbot. The frequency of flakiness increased so we should investigate that buildbot setup and load.

@whesse
Copy link
Member

whesse commented Sep 13, 2012

Issue #2708 has been merged into this issue.

@ricowind
Copy link
Contributor

This is back again, the last investigation did not seem to indicate that the bot was under heavy load and the current occurrence does not indicate that the run was slower than the previous run (on the contrary actually, it is slightly faster)

http://build.chromium.org/p/client.dart/builders/vm-win32-release/builds/12866/steps/tests/logs/stdio

VM team: how do we implement sleep? do we use windows timer granularity (which is pretty bad, something like 15 ms as far as I remember)


cc @iposva-google.
cc @sgmitrovic.
Removed the owner.
Removed Area-Build label.
Added Area-VM label.

@ricowind
Copy link
Contributor

Issue #9199 has been merged into this issue.

@dgrove
Copy link
Contributor

dgrove commented Mar 19, 2013

This problem has suddenly started making it very difficult to get a build out.

see
http://build.chromium.org/p/client.dart/builders/dartium-win-full-trunk/builds/85/steps/drt_core_unchecked_tests/logs/stdio

http://build.chromium.org/p/client.dart/builders/dartium-win-full-trunk/builds/83/steps/drt_core_unchecked_tests/logs/stdio

Can someone on the VM team please take a look at this, or disable the teset?


Removed Priority-Medium label.
Added Priority-Critical label.

@dgrove
Copy link
Contributor

dgrove commented Mar 20, 2013

Marked flaky in r20266, so this won't block the builds any longer.


Removed Priority-Critical label.
Added Priority-Medium label.

@sgjesse
Copy link
Contributor

sgjesse commented May 3, 2013

Issue #10409 has been merged into this issue.

@iposva-google
Copy link
Contributor Author

Added this to the Later milestone.
Removed Priority-Medium label.
Added Priority-Low label.

@iposva-google
Copy link
Contributor Author

The issue in comment #­3 and comment #­4 is unrelated to this original bug report. I will unmerge the issues.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@iposva-google iposva-google added Type-Defect P3 A lower priority bug or feature request area-vm labels Aug 4, 2014
@iposva-google
Copy link
Contributor Author

Stale.

@peter-ahe-google
Copy link
Contributor

I've skipped the test. At least the following alternatives are available:

  • Wrap the test in a loop and report a failure only if the test is more flaky than expected.
  • Move the test to an FYI builder.
  • Delete the test.

Marking it as flaky in a status file serves no purpose.

@ricowind
Copy link
Contributor

There are no current VM people cc'ed on this
cc @a-siva for triage

@peter-ahe-google
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

8 participants