Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve css api #5048

Closed
jmesserly opened this issue Sep 10, 2012 · 19 comments
Closed

improve css api #5048

jmesserly opened this issue Sep 10, 2012 · 19 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html type-enhancement A request for a change that isn't a bug

Comments

@jmesserly
Copy link

See CSSStyleDeclaration:

http://api.dartlang.org/docs/continuous/dart_html/CSSStyleDeclaration.html

A lot of these methods should have better types than "String". I think we need to give CSS APIs the same overhaul we gave to DOM APIs.

(Could've sworn I filed this already, but I can't find it, apologies if this is a dupe...)

@jmesserly
Copy link
Author

Another note: the feedback is not very useful if you pass something incorrect. That's one of the big problems with accepting Strings.

@sethladd
Copy link
Contributor

See also issue #4895

@blois
Copy link
Contributor

blois commented Oct 15, 2012

Added this to the Later milestone.

@efortuna
Copy link
Contributor

Set owner to @efortuna.
Removed this from the Later milestone.
Added this to the M5 milestone.
Added jquery label.

@blois
Copy link
Contributor

blois commented May 29, 2013

Removed this from the M5 milestone.
Added this to the M6 milestone.

@efortuna
Copy link
Contributor

Just checked in https://codereview.chromium.org//19786005 at r25235, which adds the Dimension class for simple CSS parsing of lengths, as a move towards this direction. More to come.

@jmesserly
Copy link
Author

\o/

@efortuna
Copy link
Contributor

Removed this from the M6 milestone.
Added this to the M7 milestone.
Removed Type-Defect label.
Added Type-Enhancement label.

@efortuna
Copy link
Contributor

Issue #9230 has been merged into this issue.

@efortuna
Copy link
Contributor

Issue #3826 has been merged into this issue.

@efortuna
Copy link
Contributor

efortuna commented Sep 9, 2013

Issue #13058 has been merged into this issue.

@efortuna
Copy link
Contributor

Update on this -- We have a design that people have signed off on, but it involves actually writing this functionality as a separate package. Since we're really close to the end of M7, we're pushing this one back to a later milestone.

Rest assured, it will get done! We have a clear plan forward. There are just higher priority issues that we have to deal with in the immediate future.


Removed this from the M7 milestone.
Added this to the Later milestone.

@efortuna
Copy link
Contributor

@efortuna
Copy link
Contributor

efortuna commented Oct 3, 2013

Issue #9355 has been merged into this issue.


cc @jacob314.
cc @jmesserly.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@DartBot
Copy link

DartBot commented Jun 3, 2014

This comment was originally written by @Emasoft


We need to eliminate all strings, because they are not type checked and a source of bugs. Classes should be made for every css type and parameter. Images, coordinates, gradients, shapes, animations, etc. should be passed to strongly typed Dart methods corresponding to all the css classes. This would also simplify the creation of higer level classes for css higher level components programmatically, like css buttons or 9-slices resizable borders.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@jmesserly jmesserly added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Aug 4, 2014
@jmesserly
Copy link
Author

I think we ended up in a good place here. Closing

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants