New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve css api #5048
Comments
Another note: the feedback is not very useful if you pass something incorrect. That's one of the big problems with accepting Strings. |
See also issue #4895 |
Added this to the Later milestone. |
Just checked in https://codereview.chromium.org//19786005 at r25235, which adds the Dimension class for simple CSS parsing of lengths, as a move towards this direction. More to come. |
\o/ |
Removed this from the M6 milestone. |
Issue #9230 has been merged into this issue. |
Issue #3826 has been merged into this issue. |
Issue #13058 has been merged into this issue. |
Update on this -- We have a design that people have signed off on, but it involves actually writing this functionality as a separate package. Since we're really close to the end of M7, we're pushing this one back to a later milestone. Rest assured, it will get done! We have a clear plan forward. There are just higher priority issues that we have to deal with in the immediate future. Removed this from the M7 milestone. |
Issue #9355 has been merged into this issue. cc @jacob314. |
Removed Area-HTML label. |
This comment was originally written by @Emasoft We need to eliminate all strings, because they are not type checked and a source of bugs. Classes should be made for every css type and parameter. Images, coordinates, gradients, shapes, animations, etc. should be passed to strongly typed Dart methods corresponding to all the css classes. This would also simplify the creation of higer level classes for css higher level components programmatically, like css buttons or 9-slices resizable borders. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
I think we ended up in a good place here. Closing |
See CSSStyleDeclaration:
http://api.dartlang.org/docs/continuous/dart_html/CSSStyleDeclaration.html
A lot of these methods should have better types than "String". I think we need to give CSS APIs the same overhaul we gave to DOM APIs.
(Could've sworn I filed this already, but I can't find it, apologies if this is a dupe...)
The text was updated successfully, but these errors were encountered: