Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move samples/ui_lib and samples/swarm to tests/benchmark_size #4827

Closed
jmesserly opened this issue Aug 29, 2012 · 13 comments
Closed

move samples/ui_lib and samples/swarm to tests/benchmark_size #4827

jmesserly opened this issue Aug 29, 2012 · 13 comments
Assignees
@nicolasgarnier
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used.

Comments

@jmesserly
Copy link

The sample isn't maintained. It's mainly used for JS code size metrics at this point.
@jmesserly
Copy link
Author

also should include a README that it only exists for testing purposes. The README can link to blog.dartwatch.com/p/community-dart-packages-and-examples.html for UI libraries.

@dgrove
Copy link
Contributor

dgrove commented Oct 10, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@dgrove
Copy link
Contributor

dgrove commented Dec 21, 2012

Removed this from the M2 milestone.
Added this to the M3 milestone.

@anders-sandholm
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@larsbak
Copy link

larsbak commented May 28, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@sethladd
Copy link
Contributor

sethladd commented Jan 7, 2014

Set owner to shaile...@google.com.

@DartBot
Copy link

DartBot commented Jan 9, 2014

This comment was originally written by shaile...@google.com

Swarm should be moved out of the samples directory and into a new samples-dev directory.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@srawlins
Copy link
Member

srawlins commented Aug 3, 2014

This can be closed, yes? It appears swarm/ has been moved into sample-dev/, and ui_lib/ doesn't appear to be in samples/ anymore.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@DartBot
Copy link

DartBot commented Oct 14, 2014

This comment was originally written by shaile...@google.com

Set owner to @nicolasgarnier.

@jmesserly jmesserly added Type-Defect area-samples (deprecated) Deprecated: this label is no longer actively used. labels Oct 14, 2014
@jmesserly
Copy link
Author

ideally we'd have moved to test/... instead of sample-dev/..., but seems good enough

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasgarnier nicolasgarnier

Labels
area-samples (deprecated) Deprecated: this label is no longer actively used.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@sethladd @kevmoo @srawlins @jmesserly @dgrove @kasperl @anders-sandholm @nicolasgarnier @larsbak @DartBot