Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser error recovery going too far #4482

Closed
stevemessick opened this issue Aug 13, 2012 · 12 comments
Closed

Parser error recovery going too far #4482

stevemessick opened this issue Aug 13, 2012 · 12 comments
Assignees
@bwilkerson
Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

floitsch: bad error message.
For the following line (note the extra ")" at the end of the line:
String lazyGetter = compiler.namer.isolateLazyInitializerAccess(element));

I get the following error-message (marking "String lazyGetter" red):
Multiple markers at this line
        - Unexpected token 'IDENTIFIER' (expected ';')
        - String is a class and cannot be used as an
         expression
////////////////////////////////////////////////////////////////////////////////////
Editor: 10557
OS: Linux - amd64 (2.6.32-41-generic)
JVM: 1.6.0_24

SDK installed: true
Dartium installed: true
@bwilkerson
Copy link
Member

Removed this from the M1 milestone.
Added this to the Later milestone.
Removed Area-Editor label.
Added Area-Analyzer label.

@bwilkerson
Copy link
Member

Removed this from the Later milestone.
Added this to the M3 milestone.

@scheglov
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the Later milestone.
Added AnalysisEngine label.

@DartBot
Copy link

DartBot commented Apr 7, 2013

This comment was originally written by amouravski@google.com

Added Editor-AnalysisEngine label.

@bwilkerson
Copy link
Member

Removed AnalysisEngine, Editor-AnalysisEngine labels.

@scheglov
Copy link
Contributor

scheglov commented May 7, 2013

New analyzer behaves better, it marks read only place where ')' is.
However there are still too many problems reported.

main() {
  var compiler;
  var element;
  String lazyGetter = compiler.namer.isolateLazyInitializerAccess(element));
}

Expected to find ';'
Expected to find ';'
Unexpected token ')'
Undefined name ''

Ideally would be great to have just one: Unexpected token ')'

@bwilkerson
Copy link
Member

Added Analyzer-Recovery label.

@bwilkerson
Copy link
Member

Removed Type-Defect label.
Added Type-Enhancement label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@bwilkerson
Copy link
Member

Added Started label.

@bwilkerson
Copy link
Member

https://codereview.chromium.org/785573002/ (bleeding edge revision 42136)

We will now recover when there is a single unexpected token before a semicolon.

Added Fixed label.

@stevemessick stevemessick added Priority-Medium area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-recovery labels Dec 5, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @scheglov @kasperl @bwilkerson @stevemessick @DartBot