New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for non-prefixed PointerLock API #4463
Comments
This comment was originally written by joh...@johnmccutchan.com On further experimentation- Element.webkitRequestPointerLock() works. What is the Dart way to access pointer lock? |
It looks like we should polyfill along the lines of https://developer.mozilla.org/en-US/docs/API/Pointer_Lock_API Added this to the Later milestone. |
Removed Area-HTML label. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
Issue #15701 has been merged into this issue. |
Changed the title to: "Support for non-prefixed PointerLock API". |
With this CL https://codereview.chromium.org/750093002/ to fix webkit prefix being removed requestPointerLock() will now work. Added Fixed label. |
With this CL https://codereview.chromium.org/750093002/ to fix webkit prefix being removed requestPointerLock() will now work. |
This comment was originally written by this.is.harry....@gmail.com Is this actually fixed? I just checked out and built bleeding-edge, and while requestPointerLock isn't prefixed when compiled to dart2js, it wasn't in 1.7.2 either. However, it isn't polyfilled so it still doesn't work properly on browsers that are prefixed, such as Firefox. https://code.google.com/p/dart/issues/detail?id=15701 was marked as a duplicate of this, so I didn't want to just open a new bug for the polyfill. using Dart-to-JavaScript compiler (dart2js) version: 1.8.0-edge.42029 |
This comment was originally written by this.is.harry.ste...@gmail.com Here is a basic patch that adds polyfills for Element.requestPointerLock() and Document.exitPointerLock(). I am unsure what should be done about the onpointerlockchange and onpointerlockerror streams, since they're static const, but need to be polyfilled at runtime. Document also has a pointerLockElement, and mouse events have movementX and movementY. Attachment: |
Re-opening to check status. Set owner to @alan-knight. |
This issue was originally filed by joh...@johnmccutchan.com
Exception: NoSuchMethodException : method not found: 'get:webkitPointer'
Receiver: Instance of '_NavigatorImpl@33cc944a'
Arguments: []
Stack Trace: 0. Function: 'Object.noSuchMethod' url: 'bootstrap' line:1650 col:41
1. Function: 'JavelineDemoLaunch.JavelineDemoLaunch.' url: 'http://127.0.0.1:3030/Users/johnmccutchan/workspace/spectre/samples/javeline/demo_launcher.dart' line:93 col:49
2. Function: '::main' url: 'http://127.0.0.1:3030/Users/johnmccutchan/workspace/spectre/samples/javeline/demo_launcher.dart' line:278 col:3
The text was updated successfully, but these errors were encountered: