Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-prefixed PointerLock API #4463

Closed
DartBot opened this issue Aug 12, 2012 · 14 comments
Closed

Support for non-prefixed PointerLock API #4463

DartBot opened this issue Aug 12, 2012 · 14 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Aug 12, 2012

This issue was originally filed by joh...@johnmccutchan.com


Exception: NoSuchMethodException : method not found: 'get:webkitPointer'
Receiver: Instance of '_NavigatorImpl@33cc944a'
Arguments: []
Stack Trace: 0. Function: 'Object.noSuchMethod' url: 'bootstrap' line:1650 col:41
 1. Function: 'JavelineDemoLaunch.JavelineDemoLaunch.' url: 'http://127.0.0.1:3030/Users/johnmccutchan/workspace/spectre/samples/javeline/demo_launcher.dart' line:93 col:49
 2. Function: '::main' url: 'http://127.0.0.1:3030/Users/johnmccutchan/workspace/spectre/samples/javeline/demo_launcher.dart' line:278 col:3

@DartBot
Copy link
Author

DartBot commented Aug 12, 2012

This comment was originally written by joh...@johnmccutchan.com


On further experimentation- Element.webkitRequestPointerLock() works.

What is the Dart way to access pointer lock?

@iposva-google
Copy link
Contributor

Added Area-DOM, Triaged labels.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@rakudrama
Copy link
Member

It looks like we should polyfill along the lines of https://developer.mozilla.org/en-US/docs/API/Pointer_Lock_API


Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@efortuna
Copy link
Contributor

efortuna commented Aug 8, 2014

Issue #15701 has been merged into this issue.

@efortuna
Copy link
Contributor

efortuna commented Aug 8, 2014

Changed the title to: "Support for non-prefixed PointerLock API".

@terrylucas
Copy link
Contributor

With this CL https://codereview.chromium.org/750093002/ to fix webkit prefix being removed requestPointerLock() will now work.


Added Fixed label.

@terrylucas
Copy link
Contributor

With this CL https://codereview.chromium.org/750093002/ to fix webkit prefix being removed requestPointerLock() will now work.

@DartBot
Copy link
Author

DartBot commented Nov 29, 2014

This comment was originally written by this.is.harry....@gmail.com


Is this actually fixed? I just checked out and built bleeding-edge, and while requestPointerLock isn't prefixed when compiled to dart2js, it wasn't in 1.7.2 either. However, it isn't polyfilled so it still doesn't work properly on browsers that are prefixed, such as Firefox.

https://code.google.com/p/dart/issues/detail?id=15701 was marked as a duplicate of this, so I didn't want to just open a new bug for the polyfill.

using Dart-to-JavaScript compiler (dart2js) version: 1.8.0-edge.42029

@DartBot
Copy link
Author

DartBot commented Nov 29, 2014

This comment was originally written by this.is.harry.ste...@gmail.com


Here is a basic patch that adds polyfills for Element.requestPointerLock() and Document.exitPointerLock().

I am unsure what should be done about the onpointerlockchange and onpointerlockerror streams, since they're static const, but need to be polyfilled at runtime. Document also has a pointerLockElement, and mouse events have movementX and movementY.


Attachment:
html_dart2js.dart.patch (2.03 KB)

@alan-knight
Copy link
Contributor

Re-opening to check status.


Set owner to @alan-knight.
Added Accepted label.

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Feb 26, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

9 participants