Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart GYP settings for Visual Studio are Incorrect #4296

Closed
DartBot opened this issue Aug 1, 2012 · 9 comments
Closed

Dart GYP settings for Visual Studio are Incorrect #4296

DartBot opened this issue Aug 1, 2012 · 9 comments
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Aug 1, 2012

This issue was originally filed by Don.J.Olm...@gmail.com

GYP settings for builds within VS are incorrect.

  1. _DEBUG should be defined for Debug builds.
  2. The runtime library is not set within the GYP file so it defaults to the MultiThreadedDLL, not MultiThreadedDebugDLL.

Attached patch fixes the two issues.

Some additional issues when building in VS that are not addressed in the patch.

  1. Release builds generate debug information (could be intentional so patch does not attempt to fix).
  2. Exception handling is disabled but Dart uses STL which will attempt to use exceptions. Warnings are generated because of this.

Attachment:
build.patch (953 Bytes)
@DartBot
Copy link
Author

DartBot commented Aug 1, 2012

This comment was originally written by Don.J.Olmstead...@gmail.com

Updated patch file with spaces instead of tabs.

Attachment:
build.patch (977 Bytes)

@sethladd
Copy link
Contributor

sethladd commented Aug 6, 2012

Thanks for the patch, Don. Is this for VS 2008 or 2010 ?

Added Area-Build, Triaged labels.

@sethladd
Copy link
Contributor

sethladd commented Aug 6, 2012

Hi Don,

Please fill out http://code.google.com/legal/individual-cla-v1.0.html with your email. Thanks!

@DartBot
Copy link
Author

DartBot commented Aug 6, 2012

This comment was originally written by Don.J.Olms...@gmail.com

RuntimeLibrary applies to pre-MSBuild (-2008) and MSBuild(2010+) http://code.google.com/p/gyp/source/browse/trunk/pylib/gyp/MSVSSettings.py#­599

So that and the _DEBUG should get all VS versions up and running properly.

Form is filled out with this email address.

@ricowind
Copy link
Contributor

ricowind commented Aug 8, 2012

Landed in revision 10366, thank you for the patch, always appreciated.

Added Fixed label.

@ricowind
Copy link
Contributor

ricowind commented Aug 8, 2012

Reoppening this since I had to revert the change - it causes linking issues on our windows buildbots:
http://chromegw.corp.google.com/i/client.dart/builders/vm-win32-release/builds/5639/steps/build/logs/stdio

Added Accepted label.

@DartBot
Copy link
Author

DartBot commented Aug 8, 2012

This comment was originally written by Don.J.Olmst...@gmail.com

Can the relevant portions be added to the ticket? I can't access that url to see what the linker errors are.

@anders-sandholm
Copy link
Contributor

Removed Area-Build label.
Added Area-Infrastructure label.

@DartBot DartBot added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Nov 20, 2013
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@athomas
Copy link
Member

athomas commented Nov 15, 2017

Closing. GYP is long gone.

@athomas athomas closed this as completed Nov 15, 2017
@pq pq mentioned this issue Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sethladd @kevmoo @anders-sandholm @ricowind @DartBot @athomas