Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderingContext pixelStorei second param should be Dynamic #4258

Closed
sethladd opened this issue Jul 30, 2012 · 9 comments
Closed

WebGLRenderingContext pixelStorei second param should be Dynamic #4258

sethladd opened this issue Jul 30, 2012 · 9 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-webgl P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sethladd
Copy link
Contributor

Currently, the second param is an int

See http://api.dartlang.org/html/WebGLRenderingContext.html#pixelStorei

However, according to http://www.khronos.org/registry/webgl/specs/1.0/#PIXEL_STORAGE_PARAMETERS the second param can be a boolean or an unsigned long.
@sethladd
Copy link
Contributor Author

From the WebGL spec:

void pixelStorei(GLenum pname, GLint param) (OpenGL ES 2.0 §3.6.1, man page)
In addition to the parameters in the OpenGL ES 2.0 specification, the WebGL specification accepts the parameters UNPACK_FLIP_Y_WEBGL, UNPACK_PREMULTIPLY_ALPHA_WEBGL and UNPACK_COLORSPACE_CONVERSION_WEBGL. See Pixel Storage Parameters for documentation of these parameters.

@sethladd
Copy link
Contributor Author

If we don't want to use Dynamic, we can test if 1 == true and 0 == false in this case, and document it.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 17, 2012

Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@alan-knight
Copy link
Contributor

Removed Library-Html label.
Added Library-WebGl label.

@sethladd sethladd added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-webgl labels Jan 14, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@terrylucas
Copy link
Contributor

The IDL defines as:

void pixelStorei(GLenum pname, GLint param);

Both are ints

The 2nd value can behave as a boolean zero is false. Any non-zero value is interpreted as true.

I don't think there's anything we have to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-webgl P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sethladd @kevmoo @terrylucas @vsmenon @kasperl @alan-knight @iposva-google