Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heap growth control causes Dart2JSCompileAll to degrade significantly #3975

Closed
a-siva opened this issue Jul 3, 2012 · 14 comments
Closed

heap growth control causes Dart2JSCompileAll to degrade significantly #3975

a-siva opened this issue Jul 3, 2012 · 14 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@a-siva
Copy link
Contributor

a-siva commented Jul 3, 2012

When heap growth control is turned off the dart2js compile all benchmark runs as follows:

Dart2JSCompileAll(RunTime): 702174

with heap growth control turned on the numbers are:

Dart2JSCompileAll(RunTime): 1428801

We expect a slight degradation but this seems pretty significant and seems to indicate that the heap growth policy heuristics needs some tweaking.
@lexprfuncall
Copy link

I would imagine that this is caused by our miserly increments of heap growth. How can I reproduce this issue?

Set owner to @a-siva.
Added NeedsInfo label.

@a-siva
Copy link
Contributor Author

a-siva commented Jul 10, 2012

run_vm_test --benchmarks

with and without heap growth control enabled should demonstrate the problem.

@a-siva
Copy link
Contributor Author

a-siva commented Jul 14, 2012

Set owner to @lexprfuncall.

@lexprfuncall
Copy link

Added Started label.

@lexprfuncall
Copy link

This benchmark allocates about 6MB in new space and about 10MB in old space. This is a pathological case for the page space growth controller because all allocations are retained so every byte allocated must be traced at the next old space collection.

The performance of the mark sweep collection can improved by increasing the growth rate and thereby reducing the number of times live storage must be traced before reaching a steady state. However, at the same time a complementary policy must be added to reduce the growth rate to its original value.

@lexprfuncall
Copy link

Set owner to @iposva-google.

@iposva-google
Copy link
Contributor

Added this to the M2 milestone.

@iposva-google
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the M3 milestone.

@iposva-google
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@larsbak
Copy link

larsbak commented May 28, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@iposva-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Unassigned label.

@iposva-google
Copy link
Contributor

Removed this from the M5 milestone.

@iposva-google
Copy link
Contributor

Removed the owner.
Added Triaged label.

@a-siva a-siva added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Oct 2, 2013
@iposva-google
Copy link
Contributor

Stale.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jan 10, 2023
@pq
linter avoid_field_initializers_in_const_classes cherry-pick
fc1ca5c 
Cherry-picks a fix to `avoid_field_initializers_in_const_classes` (dart-lang/linter#3974).

git log:

commit 8f7b75f8a3501ca2c4d5bbc1f003d90d66447544 (HEAD -> release, origin/release)
Author: Phil Quitslund <pq@users.noreply.github.com>
Date:   Mon Jan 9 09:39:48 2023 -0800

    remove unsafe null-check (#3975)

commit 79b8433
Author: Phil Quitslund <pq@users.noreply.github.com>
Date:   Thu Dec 15 09:50:23 2022 -0800

    1.32.0 (#3916)


------------------------------------------------------------------
------------------------------------------------------------------

Change-Id: I57afab3aadf23da96a2e9f596edfde5db71297ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278685
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @lexprfuncall @iposva-google @larsbak @a-siva