New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heap growth control causes Dart2JSCompileAll to degrade significantly #3975
Comments
run_vm_test --benchmarks with and without heap growth control enabled should demonstrate the problem. |
Set owner to @lexprfuncall. |
Added Started label. |
This benchmark allocates about 6MB in new space and about 10MB in old space. This is a pathological case for the page space growth controller because all allocations are retained so every byte allocated must be traced at the next old space collection. The performance of the mark sweep collection can improved by increasing the growth rate and thereby reducing the number of times live storage must be traced before reaching a steady state. However, at the same time a complementary policy must be added to reduce the growth rate to its original value. |
Set owner to @iposva-google. |
Added this to the M2 milestone. |
Removed Priority-Medium label. |
Removed this from the M5 milestone. |
Removed the owner. |
Stale. |
Cherry-picks a fix to `avoid_field_initializers_in_const_classes` (dart-lang/linter#3974). git log: commit 8f7b75f8a3501ca2c4d5bbc1f003d90d66447544 (HEAD -> release, origin/release) Author: Phil Quitslund <pq@users.noreply.github.com> Date: Mon Jan 9 09:39:48 2023 -0800 remove unsafe null-check (#3975) commit 79b8433 Author: Phil Quitslund <pq@users.noreply.github.com> Date: Thu Dec 15 09:50:23 2022 -0800 1.32.0 (#3916) ------------------------------------------------------------------ ------------------------------------------------------------------ Change-Id: I57afab3aadf23da96a2e9f596edfde5db71297ec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278685 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
When heap growth control is turned off the dart2js compile all benchmark runs as follows:
Dart2JSCompileAll(RunTime): 702174
with heap growth control turned on the numbers are:
Dart2JSCompileAll(RunTime): 1428801
We expect a slight degradation but this seems pretty significant and seems to indicate that the heap growth policy heuristics needs some tweaking.
The text was updated successfully, but these errors were encountered: