Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/language/override_field_test.dart incorrectly asserts that fields cannot be overridden #3751

Closed
peter-ahe-google opened this issue Jun 19, 2012 · 9 comments
Assignees

Comments

@peter-ahe-google
Copy link
Contributor

I believe this test is incorrect:

class A {
  int instanceFieldInA;
}

class B extends A {
  int instanceFieldInA;
}

main() {
  var x = new B();
}

Gilad, could you please advice and assign to me when you have an answer?

@gbracha
Copy link
Contributor

gbracha commented Jun 19, 2012

I'm guessing from the summary that the test claims this code is illegal? We have changed the spec so that overriding fields is permitted. So the code is correct as it stands, and any test that denies that is wrong.


Set owner to @peter-ahe-google.
Added Accepted label.

@dgrove
Copy link
Contributor

dgrove commented Oct 15, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@peter-ahe-google
Copy link
Contributor Author

Removed this from the M2 milestone.
Added this to the M3 milestone.

@peter-ahe-google
Copy link
Contributor Author

Removed this from the M3 milestone.
Added this to the M4 milestone.

@larsbak
Copy link

larsbak commented May 28, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@srawlins
Copy link
Member

This was fixed in 99c505e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants