Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: please validate positions #3675

Closed
peter-ahe-google opened this issue Jun 15, 2012 · 8 comments
Closed

dart2js: please validate positions #3675

peter-ahe-google opened this issue Jun 15, 2012 · 8 comments
Labels
P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

We should add an assertion that ensures that all tokens are found between the begin and end token of the current element.

The current API is quite subtle and requires compiler engineers to be very careful about calling Compiler.withCurrentElement when reporting an error on an element that is being inlined. So it is easy to forget that.

Also, as some tokens are synthesized by the parser, we should probably record the original token in synthesized tokens. This will make the proposed validation easier to implement.
@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.
Removed Priority-Low label.
Added Priority-Medium label.

@peter-ahe-google
Copy link
Contributor Author

Removed Priority-Medium label.
Added Priority-Low label.

@peter-ahe-google
Copy link
Contributor Author

Removed this from the M2 milestone.
Added this to the Later milestone.
Removed Priority-Low label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.
Changed the title to: "dart2js: please validate positions".

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sigmundch sigmundch added P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable and removed Priority-Medium labels Dec 10, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Dec 1, 2022
@sigurdm
Bump pub to 21aa23f148a428ae4dd97a27ecc70b08c1328089
258598e 
Changes:
```
> git log --format="%C(auto) %h %s" 4fd2051..21aa23f
 https://dart.googlesource.com/pub.git/+/21aa23f1 Revert "Create output folder if it doesn't exist in the precompiler (#3676)" (#3677)
 https://dart.googlesource.com/pub.git/+/04f7bce8 Don't consider resolution outdated in dev-releases (#3678)
 https://dart.googlesource.com/pub.git/+/74473e12 Create output folder if it doesn't exist in the precompiler (#3676)
 https://dart.googlesource.com/pub.git/+/5bfd68b1 Avoid .incremental.dill.incremental.dill in temporary file name (#3675)
 https://dart.googlesource.com/pub.git/+/c3870bc1 Unskip test (#3671)

```

Diff: https://dart.googlesource.com/pub.git/+/4fd2051bb8060ea2f2e02b13dfeb2f793d197994..21aa23f148a428ae4dd97a27ecc70b08c1328089/
Change-Id: Ie5060563cc3f96b0bc52e542f7a7b19d17fefd8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273223
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @sigmundch @kasperl @peter-ahe-google