Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please test --package-root #3170

Closed
peter-ahe-google opened this issue May 22, 2012 · 12 comments
Closed

Please test --package-root #3170

peter-ahe-google opened this issue May 22, 2012 · 12 comments
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@peter-ahe-google
Copy link
Contributor

We need a test of the --package-root command line.

@peter-ahe-google
Copy link
Contributor Author

This should include testing stuff like issue #3147.

@peter-ahe-google
Copy link
Contributor Author

Added this to the M2 milestone.
Marked this as being blocked by #3168.
Unmarked this as being blocked by #3168.

@whesse
Copy link
Member

whesse commented Aug 24, 2012

Can you use --special-command for this?

@peter-ahe-google
Copy link
Contributor Author

I don't think so. I need to write a few tests with different --package-root arguments, not run the test suite N times with different command-line arguments.

@DartBot
Copy link

DartBot commented Oct 2, 2012

This comment was originally written by adamle...@gmail.com


One test case from me:
dart --enable-checked-mode --package-root=C:\dart-sdk\pkg\ lib\Adder.dart
fails

but
dart --enable-checked-mode --package-root=CC:\dart-sdk\pkg\ lib\Adder.dart
works fine

Windows7, Dart 13122

For the sake of completeness, Adder.dart:

#library('mylib');
#import('package:unittest/unittest.dart');
class Adder {
  int add(int a, int b) {
    return a+b;
  }
}

void main() {
  test('aaa', (){
    var adder = new Adder();
    expect(adder.add(2,4), equals(6));
  });
}

@peter-ahe-google
Copy link
Contributor Author

Removed this from the M2 milestone.
Added this to the M3 milestone.

@peter-ahe-google
Copy link
Contributor Author

Removed this from the M3 milestone.
Added this to the M4 milestone.

@larsbak
Copy link

larsbak commented May 28, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@peter-ahe-google peter-ahe-google added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 4, 2014
@peter-ahe-google peter-ahe-google self-assigned this Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@matanlurey
Copy link
Contributor

I imagine the CFE is sufficient here.

@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 22, 2018
copybara-service bot pushed a commit that referenced this issue Oct 8, 2021
Changes:
```
> git log --format="%C(auto) %h %s" 37d0592..0764437
 https://dart.googlesource.com/pub.git/+/07644370 Make gitignore validator use gitignores from repo-root and down. (#3169)
 https://dart.googlesource.com/pub.git/+/205ea58c Handle build-versions when reformatting ranges (#3170)
 https://dart.googlesource.com/pub.git/+/8f7bfb8c migrate 3 leaf files to null-safety (#3168)
 https://dart.googlesource.com/pub.git/+/df5db1f1 Extract some parts of pubspec parsing to a null-safe library. (#3160)

```

Diff: https://dart.googlesource.com/pub.git/+/37d05928939b3100e7e55c3dff922651db1de1e1~..0764437088fd58eb7af779ecef66bab40dfcf2e9/
Change-Id: I8d938dbf6c3fba3c3f4d98bbaa5835acfaf132a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216020
Reviewed-by: Sarah Zakarias <zarah@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

7 participants