Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test.dart gives false positives for tests with no output #2982

Closed
nex3 opened this issue May 9, 2012 · 7 comments
Closed

test.dart gives false positives for tests with no output #2982

nex3 opened this issue May 9, 2012 · 7 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@nex3
Copy link
Member

nex3 commented May 9, 2012

If test.dart runs a test file and it produces no output, that's considered a success. This means that if a test is somehow failing to run, it's incorrectly considered successful. It seems like test.dart should explicitly verify that the tests are printing PASS.
@ricowind
Copy link
Contributor

Assigning to you Bill (this is overlapping with other discussions/fixes)

cc @mkustermann.
Set owner to @whesse.

@ricowind
Copy link
Contributor

Removed Area-Test label.
Added Area-Infrastructure label.

@mkustermann
Copy link
Member

@NweiZ: Please note that the majority of our tests are not using the unittest framework. They are not printing PASS.

@nex3
Copy link
Member Author

nex3 commented Nov 21, 2013

It's easy to determine if a test is using unittest (or scheduled_test, which wraps it).

@ricowind
Copy link
Contributor

+siggi,+pete (just fyi)
There should be a specific contract on how tests report that they are asynchronous, and how they report that they are done with success or done with failure. It is not a good idea to make special casing depending on if the test is using the unittest, scheduled_test, async helper, my awesome async testing framework with build in heat or not.
There are a bunch of tests that will not run any actual tests on specific platforms, see discussion here:
https://codereview.chromium.org/75393002/

cc @sigmundch.
cc @blois.

@nex3 nex3 added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Nov 26, 2013
@kevmoo
Copy link
Member

kevmoo commented Feb 1, 2016

@nex3 Is still in the realm of an issue?

@nex3
Copy link
Member Author

nex3 commented Feb 1, 2016

No, this can be closed out.

@nex3 nex3 closed this as completed Feb 1, 2016
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nex3 @kevmoo @whesse @ricowind @mkustermann