Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override "annotation" #2954

Closed
dgrove opened this issue May 9, 2012 · 5 comments
Closed

Override "annotation" #2954

dgrove opened this issue May 9, 2012 · 5 comments
Assignees
@gbracha
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). type-enhancement A request for a change that isn't a bug

Comments

@dgrove
Copy link
Contributor

dgrove commented May 9, 2012

We need some way to indicate overrides:

  1. This will prevent overridden methods from defaulting to a superclass when the method call is renamed in the superclass and the caller, but not the subclass. If the subclass's overriden method is annotated, then the subclass should fail static analysis at compile time.
  2. This will offer devel-time support for refactorings
@gbracha
Copy link
Contributor

gbracha commented May 9, 2012

Added Accepted label.

@gbracha
Copy link
Contributor

gbracha commented May 24, 2012

We will try and deal with this in the context of a general purpose annotation facility.

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@dgrove dgrove added Type-Enhancement area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Aug 4, 2014
@peter-ahe-google peter-ahe-google mentioned this issue Jun 3, 2015
Closed
@rmacnak-google
Copy link
Contributor

There is a standard annotation 'override' in dart:core.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbracha gbracha

Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @dgrove @kasperl @gbracha @rmacnak-google